JusticeRage / ApkTrack

ApkTrack is an Android app which checks if updates for installed APKs are available.
GNU General Public License v3.0
122 stars 27 forks source link

Updated English and German strings WRT liability and consistency of their wording, mostly unifying the use of "apps" / "applications" to "apps" only #122

Closed Olf0 closed 6 years ago

Olf0 commented 6 years ago

While I originally intended to create two separate pull requests for the English and German strings, I messed this up in my internal branches, so I had to merge the English language changes into the German ones to avoid manual conflict resolution. Most of the German language fixes and improvements are due to messing them up in a similar manner two days ago, without noticing this early enough. A few improvements originate from the fact, that it is quite helpful to jump back and forth between those two languages, as this helps to have a deeper understanding how to express things concisely.

JusticeRage commented 6 years ago

Thanks! One additional advice I would give you is to try to avoid very small commits, to keep the whole tree more readable. For instance, 41504524b4fc3bed10edebfb4e04cdf4b0a2d2b3 is very small and could easily have been grouped with all the other ones.

Olf0 commented 6 years ago

Yes, I know, but "avoiding small commits" is one of the things I still have trouble with:

So how do I do this better, technically?

JusticeRage commented 6 years ago

I think the best way to proceed would be like this:

I'm not very familiar with squashing, but I assume that you're having conflicts because you work from different machines simultaneously. BTW, that's just my personal workflow, it's not an industry standard or anything. Other projects may have different approaches.

Olf0 commented 6 years ago

Thanks a lot for your recommendations, --amend was new to me.

But for this "warming up" round with Git / Github, I avoided bullet point 1 yet, "Work locally on your machine ..." in order not to be confronted with too many obstacles at one time. In hindsight it might have been easier to do it properly (thus locally), but initially I considered this to be just a few small changes, which can be easily done in the online editor.

As I have just a single further commit planned for this "warming up" round, which is to introduce the recent changes to README.md into http://apktrack.org, i.e. the gh-pages branch, I will do my best to deliver it in a single pull request, while still editing online.

P.S.: Also astonishing for me to see the changes I carried out in my Github repository to show up here!?! And pulling from your beta branch to mine created an entry "referenced this pull request" here, which appears to be even stranger to me. I guess I am now ready to read a "practical introduction to git", as I know much about its concepts (although with a couple of gaps), but many things look strange to me in practice (which is presumably just a lack of understanding).