Only wrap jobs that inherit ActiveJob::Base

JustinAiken / active_scheduler

Resque Scheduling for ActiveJob

MIT License

74 stars 20 forks source link

Only wrap jobs that inherit ActiveJob::Base #3

Closed ximus closed 8 years ago

ximus commented 8 years ago

Hi,

We have a lot of jobs in our resque schedule that are not ActiveJob::Base descendants, just plain old resque jobs pre-dating active job. We want to support activejobs moving forward in our resque schedule, but are not interested to update the existing jobs.

This changes active_scheduler to not assume every job in the schedule is an active job, at the marginal expense of looking up class objects (.constantize) when wrapping the config, which is fine for us.

coveralls commented 8 years ago

Coverage remained the same at 100.0% when pulling e56ae9008724dd957870808eac89cc84f3f84114 on ximus:only-wrap-active-jobs into 0d6993a395248898eee7366c3a2fd3d13429de75 on JustinAiken:master.

JustinAiken commented 8 years ago

Cool, useful idea for people mid-transition to AJ!

Released as 0.1.0