search

JustinBeckwith / linkinator

🐿 Scurry around your site and find all those broken links.
MIT License
1.03k stars 80 forks source link

Links containing search params are reported as broken #595

Open maddsua opened 7 months ago

maddsua commented 7 months ago

Simple example: a link like /checkout?services=setup-cctv would be reported as broken. Fixing this should be pretty easy tho. Gotta check the code, and I'll probably create a MR for it

maddsua commented 7 months ago

Oh interesting, so what's broken in my case is a redirect. In fact, that /checkout page is not /checkout.html but at /checkout/index.html. But I don't feel like just slapping a regex replace on top of it, what actually fails is the file server, redirect just doesn't try to prevent it from happening and that's why adding that regex replace fixed it for me

maddsua commented 7 months ago

So, I made a PR that fixes the issue: #596 I mean, I get that you're probably busy with more important things, but it would be nice to get this one done

maddsua commented 7 months ago

Hey @JustinBeckwith, don't want to be annoying or anything but I think that fixing this thing is kinda important

maddsua commented 4 months ago

Hi again! Is there any chance this fix will be merged anytime soon? I mean, it breaks a few of my apps and I would hate to switch to a different link checker just because of that 😂 @JustinBeckwith