search

JustinBeckwith / yes-https

Say yes to https with express and connect.
MIT License
31 stars 2 forks source link

Breaks GAE Cron #1

Closed Splaktar closed 7 years ago

Splaktar commented 7 years ago

Ever since we deployed with this, all of our Cron jobs have been failing because they are getting 301 status back.

Just like the health check hack, I think that we need a hack for allowing HTTP requests that have the X-Appengine-Cron: true header.

JustinBeckwith commented 7 years ago

This is fixed by 38f1f79b555bce9b74c93ff85fb2569ee5fb88d0 - I'm just giving you an additional filter method where you can opt out of specific requests. Check out:

https://github.com/JustinBeckwith/yes-https#ignoring-specific-requests

Hope this helps!

Splaktar commented 7 years ago

@JustinBeckwith I would expect more details from the new docs. Especially a listing of important exceptions and code snippet for App Engine specifically. Otherwise people who try this library are going to run into the health check and cron issues repeatedly. That doesn't make for a good DX.