JustinByrne / Mealing

Simple application to generate weekly menus while providing list of ingredients for each meal to build a shopping list. WIP
MIT License
103 stars 33 forks source link

Images for Recipes aren't loaded. #12

Open khandah opened 2 years ago

khandah commented 2 years ago

It is impossible to load and display images for recipes.

JustinByrne commented 2 years ago

Have you ensured that your APP_URL in the .env file is correct. For example when using php artisan serve this usually serves the app on http:127.0.0.1:8000 if you are doing this you will need to also add the port to the .env file.

khandah commented 2 years ago

I can add them. I mean they are loaded (100%), but not displayed. I added SERVER_PORT=8001 8001 is my port and it is still the same.


From: Justin Byrne @.> Sent: December 20, 2021 2:07 AM To: JustinByrne/Mealing @.> Cc: khandah @.>; Author @.> Subject: Re: [JustinByrne/Mealing] Images for Recipes aren't loaded. (Issue #12)

Have you ensured that your APP_URL in the .env file is correct. For example when using php artisan serve this usually serves the app on http:127.0.0.1:8000 if you are doing this you will need to also add the port to the .env file.

— Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJustinByrne%2FMealing%2Fissues%2F12%23issuecomment-997652994&data=04%7C01%7C%7C96b79b40ebd44f40630108d9c38764ca%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637755808545645969%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=QimqmiuL7e3PUz77mNcaoBlU5tu4U%2FIFhvxA%2BPezaKY%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACWXOVCXOCKW6VYUCE3X7A3UR3I3JANCNFSM5KMPN66A&data=04%7C01%7C%7C96b79b40ebd44f40630108d9c38764ca%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637755808545645969%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=hSheEzFNJVcEvxuFUwZmcJFo2TxdqXwD9tfp6CV0GgE%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C96b79b40ebd44f40630108d9c38764ca%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637755808545645969%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=5bTiy7%2Be7C7wInjLLXWv6%2Fj2wj7QZo0%2FUeUfgOzGTaM%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C96b79b40ebd44f40630108d9c38764ca%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637755808545645969%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=kam0Izpo%2FGcsLKliBoYENHts1Ef2Fn1zM2f5f%2B0naHc%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

JustinByrne commented 2 years ago

Okay so your .env file has the following line.

APP_URL=http://localhost:8001
khandah commented 2 years ago

Yes, that's what I added and no change.


From: Justin Byrne @.> Sent: December 20, 2021 12:32 PM To: JustinByrne/Mealing @.> Cc: khandah @.>; Author @.> Subject: Re: [JustinByrne/Mealing] Images for Recipes aren't loaded. (Issue #12)

Okay so your .env file has the following line.

APP_URL=http://localhost:8001

— Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJustinByrne%2FMealing%2Fissues%2F12%23issuecomment-998133220&data=04%7C01%7C%7C8bfaf118e10e4a20b04808d9c3debe72%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756183712295486%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=FwZiDRnsjtbZrhEpDwhMuIWual36MSvqFqWnb7ZXKwU%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACWXOVFWYX735HC5SDPWTFLUR5SEBANCNFSM5KMPN66A&data=04%7C01%7C%7C8bfaf118e10e4a20b04808d9c3debe72%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756183712295486%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=REjkplFgUvKl42IA4%2B30RBbsr6VreyKSl6G7X1IZdho%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C8bfaf118e10e4a20b04808d9c3debe72%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756183712295486%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=TZm6Bnpg2OXLApP1v7dKgHCm%2BITa4h1nIVD%2F2l6SmB0%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C8bfaf118e10e4a20b04808d9c3debe72%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756183712295486%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=pu6XWii6RmDaZcdOE%2F0fvKs2tTrYn5%2FyocxcURY7f6Y%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

JustinByrne commented 2 years ago

Once you've saved the recipe, what shows for the image, do you get something like this?

Missing image

khandah commented 2 years ago

Can't see the image you sent. What is displayed is the image with the name of the recipe.


From: Justin Byrne @.> Sent: December 20, 2021 3:56 PM To: JustinByrne/Mealing @.> Cc: khandah @.>; Author @.> Subject: Re: [JustinByrne/Mealing] Images for Recipes aren't loaded. (Issue #12)

Once you've saved the recipe, what shows for the image, do you get something like this?

[Missing image]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcamo.githubusercontent.com%2Fc29de8b4f6571aef8826571e6c8cb4571739dcdeef896c7ce8f82a15e3fd74eb%2F68747470733a2f2f692e737461636b2e696d6775722e636f6d2f6f6f5137792e706e67&data=04%7C01%7C%7C1157efb9300b4ca51ca308d9c3fb3cff%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756306092116528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xq3YcDzPH0EwmFnlUduMYlB53lWnI7AZqkHz4OYKzHI%3D&reserved=0

— Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJustinByrne%2FMealing%2Fissues%2F12%23issuecomment-998263018&data=04%7C01%7C%7C1157efb9300b4ca51ca308d9c3fb3cff%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756306092116528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=J5jAA0RX6VMNoaZL7o1raHBsbnLreR%2BOc0Hv95xMtYM%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACWXOVAVAHPJEPETB6777CLUR6KA5ANCNFSM5KMPN66A&data=04%7C01%7C%7C1157efb9300b4ca51ca308d9c3fb3cff%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756306092116528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=dzzVdqDhmA0c8Es24dAbHlhAkOALAF0gLjLGjUQ0bro%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C1157efb9300b4ca51ca308d9c3fb3cff%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756306092116528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=fM4gLnBo8P8hhnU25oQOxsi6eHdxTsri4L3BPHtV%2B20%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C1157efb9300b4ca51ca308d9c3fb3cff%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756306092116528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=jWNueQTmeka6FMD4RCxWGpoBhEffcyCg12467v29Thw%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

khandah commented 2 years ago

I made some correctio and now I can display images. How can I publish the code so you can see it ?


From: Justin Byrne @.> Sent: December 20, 2021 3:56 PM To: JustinByrne/Mealing @.> Cc: khandah @.>; Author @.> Subject: Re: [JustinByrne/Mealing] Images for Recipes aren't loaded. (Issue #12)

Once you've saved the recipe, what shows for the image, do you get something like this?

[Missing image]https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcamo.githubusercontent.com%2Fc29de8b4f6571aef8826571e6c8cb4571739dcdeef896c7ce8f82a15e3fd74eb%2F68747470733a2f2f692e737461636b2e696d6775722e636f6d2f6f6f5137792e706e67&data=04%7C01%7C%7C1157efb9300b4ca51ca308d9c3fb3cff%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756306092116528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xq3YcDzPH0EwmFnlUduMYlB53lWnI7AZqkHz4OYKzHI%3D&reserved=0

— Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJustinByrne%2FMealing%2Fissues%2F12%23issuecomment-998263018&data=04%7C01%7C%7C1157efb9300b4ca51ca308d9c3fb3cff%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756306092116528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=J5jAA0RX6VMNoaZL7o1raHBsbnLreR%2BOc0Hv95xMtYM%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACWXOVAVAHPJEPETB6777CLUR6KA5ANCNFSM5KMPN66A&data=04%7C01%7C%7C1157efb9300b4ca51ca308d9c3fb3cff%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756306092116528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=dzzVdqDhmA0c8Es24dAbHlhAkOALAF0gLjLGjUQ0bro%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C1157efb9300b4ca51ca308d9c3fb3cff%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756306092116528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=fM4gLnBo8P8hhnU25oQOxsi6eHdxTsri4L3BPHtV%2B20%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C1157efb9300b4ca51ca308d9c3fb3cff%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637756306092116528%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=jWNueQTmeka6FMD4RCxWGpoBhEffcyCg12467v29Thw%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

JustinByrne commented 2 years ago

Hi, have a look at the GitHub docs regarding pull requests. Hopefully this will help.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request