search

JustinCanton / Geo.NET

A lightweight method for communicating with the multiple online geocoding APIs.
MIT License
13 stars 8 forks source link

Adding missing fields on Address model type for Here API #69

Closed Farthom closed 1 year ago

Farthom commented 1 year ago

I've begun using this package, however as I got into the weeds with my implementation I noticed some missing properties on the Here Geocoding API model types. As luck would have it... I need one of these fields... Specifically "stateCode"

I've reviewed and added missing fields on the "Address" model type, but have not reviewed the remainder of the API. The documentation I referenced is: https://developer.here.com/documentation/geocoding-search-api/api-reference-swagger.html

JustinCanton commented 1 year ago

Thank you for contributing! It seems like the build failed in the MapQuest test cases. I am going to take a look and see what is going on. It seems like it could be a concurrency issue.

JustinCanton commented 1 year ago

Re-running it seems to have worked. I will need to figure out what I can do for that. In the meantime, this PR looks good to me. I will merge this and have an alpha build you can try out.

JustinCanton commented 1 year ago

1.5.0-alpha.1 is released.