Modify index.js to handle wrapped LAS files, meaning lines longer than 80 characters get continued on next line.

JustinGOSSES / wellio.js

JavaScript for converting well-log standard .las file format to json format

https://justingosses.github.io/wellio.js/

MIT License

34 stars 5 forks source link

Modify index.js to handle wrapped LAS files, meaning lines longer than 80 characters get continued on next line. #12

Closed JustinGOSSES closed 4 years ago

JustinGOSSES commented 5 years ago

Modify index.js to handle wrapped LAS files, meaning lines longer than 80 characters get continued on next line. Current wellio.js fails with LAS files that are wrapped.

https://github.com/JustinGOSSES/wellio.js/blob/master/dist/index.js

This was first suggested by @oze4 in issue #5.

This would be a good first issue and after a quick look seems like it would involve editing lines 158-194 in index.js.

Please refer to http://www.cwls.org/las/

dcslagel commented 4 years ago

There is a test for this feature. It is currently disabled with '.skip'.

To run the test:

Edit test_read_v2_sample_wrapped.js to remove '.skip'
tape dist/test/las2json/test_read_v2_sample_wrapped.js

Note the test currently only tests that the las source file (with wrapped data) will be read without throwing an error. Once that is passed successfully additional test may need to be added to validate the data was parsed properly.

JustinGOSSES commented 4 years ago

Should we unwrap the files by default as an initial preprocessing step?

Would that create any problems?

dcslagel commented 4 years ago

@JustinGOSSES,

I am just now seeing your comment to look at unwrapping as a preprocessing step. I had been working on an alternative solution which is in pull request #31. See if it is also a satisfactory solution or if it needs changes.

Thanks, DC

dcslagel commented 4 years ago

@JustinGOSSES

With pull request #31 merged, do we want to keep this ticket open for additional work in this area or can it be closed now?

Thanks,

JustinGOSSES commented 4 years ago

I'll change this to "won't fix". ... want to keep it for now but not worked on.

dcslagel commented 4 years ago

@JustinGOSSES,

I'm wondering if we could handle this differently. Below is a proposal. See if it looks like a good way to go. If not, that's okay, but I thought I would run it by you anyways.

Move 'Unwrap the files by default as an initial preprocessing step' to a separate ticket.
Remove the 'wontfix' label and close this ticket.

The thinking for this proposal is that the integration of #31 did enable processing LAS files with wrapped lines which is this issue.

Thanks,

github-actions[bot] commented 4 years ago

Stale issue message