Create notebook or file that documents which tests fail & why & propose fixes to wellio code to fix.

JustinGOSSES / wellio.js

JavaScript for converting well-log standard .las file format to json format

https://justingosses.github.io/wellio.js/

MIT License

34 stars 5 forks source link

Create notebook or file that documents which tests fail & why & propose fixes to wellio code to fix. #16

Closed JustinGOSSES closed 4 years ago

JustinGOSSES commented 4 years ago

Create notebook or file that documents which tests fail & why & propose fixes to wellio code to fix.

Not sure best way to package this...but probably good to make a place for examples of tests that fail and reasons why first... then propose changes to wellio.js parsing code to handle. I suspect at least some of the tests fail for related reasons. This might bring them to surface.

Tagging @dcslagel as you're working in this direction. I'll be unable to spend time on this until next week.

dcslagel commented 4 years ago

@JustinGOSSES,

Would making a github issue for each of the current tests that fail.skip? The benefit of this approach is that each test issue is visible in the main GitHub display.

JustinGOSSES commented 4 years ago

Each has its benefits I suppose. Let's go with github issues as you propose though.

JustinGOSSES commented 4 years ago

Relatedly - I altered the github actions script in https://github.com/JustinGOSSES/wellio.js/tree/master/.github/workflows such that it seems to work now.

It uses the las2json and test-all scripts defined in package.json as currently set up.

Theoretically, it should give us a test fail message when a pull request is submitted that fails tests though I haven't tested that well yet.

dcslagel commented 4 years ago

@JustinGOSSES,

Per this conversation, I created issues 20 - 24 to track progress on the current test failures.