search

JustinGOSSES / wellio.js

JavaScript for converting well-log standard .las file format to json format
https://justingosses.github.io/wellio.js/
MIT License
34 stars 5 forks source link

Issues 23 and 24 fix UWI/API leading zero tests #26

Closed dcslagel closed 4 years ago

dcslagel commented 4 years ago

This change enables the unit tests for UWI and API leading zero tests. The cooresponding .las files are changed to match the spacing in the basic sample.las file. This 'space' change enables these test to pass with the current parsing algorithm.

JustinGOSSES commented 4 years ago

@dcslagel Do you think we should: (1) approve this pull request (2) create another test LAS with the old spacing and then modify code be able to deal with both spacing scenarios?

I don't know how common the old spacing is?

dcslagel commented 4 years ago

@JustinGOSSES,

Before posting, I looked through the lasio 2.0 *.las files and didn't see any other files with the close spacing (other than the uwi/api leading zero files). So I don't think it is common, and decided not to create a test case for it when uploading this change. Given that I lean toward:

  1. approve this pull request
  2. continue fixing the other tests 3, then pull in more of the lasio examples/test and make parsing improvements based on these.

If someone reports a failing file with closer spacing we can address it at that time.

Does that sound good?

Thanks,

DC

JustinGOSSES commented 4 years ago

Sounds good. Thanks for explanation.