JustinGOSSES / wellioviz

d3.js v5 visualization of well logs
https://justingosses.github.io/wellioviz/#introduction
Apache License 2.0
52 stars 12 forks source link

Added two example, non-notebook deployments #100

Closed nathangeology closed 4 years ago

nathangeology commented 4 years ago

Description

There is some reformatting of files according to the webstorm linter. The primary purpose of this pull request is to add two MVP example deployments. One to bokeh/panel and one is a simple HTML webpage deployment.

Related Issue

https://github.com/JustinGOSSES/wellioviz/issues/99#issue-632464906 Enable wellioviz to work with Dash or Panel or other python viz things

Motivation and Context

This allows users to see the basics of how to use this javascript package as a part of panel, bokeh, and (thanks to panel) plotly as well.

Types of changes

Checklist:

nathangeology commented 4 years ago

@JustinGOSSES I'm going to start working on some refactoring of the wellioviz library next as part of the hackathon. Afterwards, I'll see about adding in some more sophisticated integrations and examples.

dcslagel commented 4 years ago

Hi @nathangeology,

I tried to run the the example_panel_app by installing panel with pip install panel and running

cd wellioviz/example_deployments/example_panel_app
python main.py

and it died on this error:

Traceback (most recent call last):
  File "main.py", line 17, in <module>
    with open('panel_idx.html', 'r', encoding='utf-8') as html_file:
FileNotFoundError: [Errno 2] No such file or directory: 'panel_idx.html'

Is there additional setup steps or does panel_idx.html need to be added?

Thanks!, DC

nathangeology commented 4 years ago

try running panel serve example_panel_app --show from example_deployments directory. Also, I'm updating the html with a few changes since I moved it from the original 'myapp' folder on my machine to this examples folder for the main project. <- DONE

JustinGOSSES commented 4 years ago

This is great work @nathangeology .

I got it working pretty easily. A few thoughts:

JustinGOSSES commented 4 years ago

Do people think we should merge this pull request and keep working on it or work on pull request? My bias is to move its location then merge, but open to anything.

dcslagel commented 4 years ago

Hi @nathangeology , @JustinGOSSES ,

Great, got the panel running with Nathan's panel serve example_panel_app --show information.

How about creating a t20-wellioviz branch or next release branch and merging to there? This could work well because it would give a separate branch to do any tidying up, directory changes and other considerations as preparation for a later merge to the master.

nathangeology commented 4 years ago

Ok, the last thing is to update the documentation and then this panel example deployment should be completed. Going to work on refactoring and making better panel example apps using wellioviz.