search

JustinGOSSES / wellioviz

d3.js v5 visualization of well logs
https://justingosses.github.io/wellioviz/#introduction
Apache License 2.0
51 stars 12 forks source link

Demo.html doesn't work, need to investigate #109

Closed JustinGOSSES closed 4 years ago

JustinGOSSES commented 4 years ago

Describe the bug

bundle.js:22171 Uncaught TypeError: Cannot read property 'split' of undefined at splitLineofType1 (bundle.js:22171) at las2json (bundle.js:22199) at convert_and_startHelpers (main.js:138) at HTMLButtonElement.onclick (demo.html:80) splitLineofType1 @ bundle.js:22171 las2json @ bundle.js:22199 convert_and_startHelpers @ main.js:138 onclick @ demo.html:80 12main.js:76 Uncaught TypeError: $.ajax is not a function at readInLASFromASSETS (main.js:76) at HTMLButtonElement.onclick (demo.html:70)

JustinGOSSES commented 4 years ago

might relate to #103 or #102 ? @dcslagel

dcslagel commented 4 years ago

Is that error from running demo.html locally or from https://justingosses.github.io/wellioviz/demo.html?

Wonder if the bundle needs to be regenerated with the changes to demo.html for everything to work. I'll give that a try locally. I'll copy these changes in a demo-menu.html and post a new pull request. That way we can check for 'online' issues before merging into the live demo.html.

DC

JustinGOSSES commented 4 years ago

I saw it when running: https://justingosses.github.io/wellioviz/demo.html

The bundle suggestion sounds plausible but haven't had chance to check.

dcslagel commented 4 years ago

I can see the issue when running demo.html locally and with the browsers dev-console open. Okay the issue is caused by the by mistaken update of Jquery to Jquery-slim. Fix is in #110.

dcslagel commented 4 years ago

https://github.com/JustinGOSSES/wellioviz/pull/110 fixes this and re-adds the new menu functionality. Let me know if you would prefer these to be separate pull requests and I'll make that change.

The issue was that during the recent update of Bootstrap and its dependencies Jquery was updated to a 'slim' version that doesn't include ajax.

JustinGOSSES commented 4 years ago

Yep, merged in #110 and it is fixex

dcslagel commented 4 years ago

Great. :-)