search

JustinGOSSES / wellioviz

d3.js v5 visualization of well logs
https://justingosses.github.io/wellioviz/#introduction
Apache License 2.0
49 stars 12 forks source link

allow for commas in number scales (ie 1,500 vs 1.500) #52

Closed kernant closed 4 years ago

kernant commented 4 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

JustinGOSSES commented 4 years ago

Comma's are already the default. It might have been changed in your code you're using with wellioviz?

If you go the recent observable notebook: https://observablehq.com/@justingosses/well-log-in-d3-js-v5-notebook-2 and go to part C and go to the function: takeInArraysAndGetObjectOfCurveDataForPlotting() and put 10000 at the end of the line newObj[CurveName] = arraysOfCurvesAndNames[0][CurveName][i] like so : `newObj[CurveName] = arraysOfCurvesAndNames[0][CurveName][i]10000` you'll see the curve scale units in thousands using commas.