JustinGrote / JAz.PIM

MIT License
30 stars 2 forks source link

Add -Wait parameter for optionally waiting for role activation to complete #7

Open janegilring opened 2 years ago

janegilring commented 2 years ago

Would it make sense to add a -Wait parameter to the Enable-*Role commands in order for the commands to check for the status going from PendingProvisioning to Provisioned (similar to the portal experience)?

JustinGrote commented 2 years ago

It's on the to-do list, I already have the scaffolding for it.

JustinGrote commented 2 years ago

@janegilring added it for Azure AD in v0.0.8, give it a spin. Azure Resource roles will be a bit more complicated... https://github.com/JustinGrote/JAz.PIM/pull/9

janegilring commented 2 years ago

Very nice, it worked fine. Activation took 71 seconds in my test.

JustinGrote commented 2 years ago

I decided I'm probably gonna make this the default experience and swap the parameter to -NoWait instead

janegilring commented 2 years ago

Makes sense to me