search

JustinPihony / gradle-aws-plugin-reboot

Gradle plugin to manage Amazon Web Services
6 stars 5 forks source link

New Gradle settings need optional in many places #11

Closed JustinPihony closed 3 years ago

JustinPihony commented 3 years ago

Now that it has the Input annotation it also requires an Optional annotation for many of the fields - as they were not required previously. Most are handled in the code itself...so maybe it is better to blanket them?

JustinPihony commented 3 years ago

Actually, after understanding the annotations better I am opting for Internal all throughout. If you are invoking an aws task then it is almost certainly not something to be cached. Any exceptions to that rule should be handled as one off's in separate PRs with reasoning.

JustinPihony commented 3 years ago

Fixed in 0.45