search

JustinPihony / gradle-aws-plugin-reboot

Gradle plugin to manage Amazon Web Services
6 stars 5 forks source link

Mention breaking change in AWSLambdaMigrateFunctionTask #14

Open musketyr opened 3 years ago

musketyr commented 3 years ago

there is a breaking change when timeout has changed to lambdaTimeout without any warning notice

JustinPihony commented 3 years ago

You are correct - I will modify the release notes to signify the breaking change. It had to do with the Gradle 7.1 upgrade where it conflicted with getTimeout added to ConventionTask

JustinPihony commented 3 years ago

Another option could be to use the timeout built into the AbstractTask (not sure why I didn't try it then) - I may look into that first and see if it is usable in the same fashion

musketyr commented 3 years ago

That's probably not the best idea. Let's say that someone would like to timeout the upload task itself because of for example bad connection then there will be no option how to set this separately.