JustinSoh / pe

0 stars 0 forks source link

Lack of Return Flow Arrow and Lifeline in Application Flow Sequence Diagram (C) #11

Open JustinSoh opened 2 months ago

JustinSoh commented 2 months ago

Description: The call from FAP to Storage using saveModulesToFilePath() has no lifeline at Storage and lack a return of flow control back to the FAP class. Refer to the area marked (c)

Steps to Reproduce:

  1. Open the user manual to the section titled Below is a Sequence diagram that describes the application loop:

Expected Result: There should be some form of flow control returning back to the FAP class. For instance in this picture, the stressTest() is called and then the flow is return back after it has been processed

image.png

Actual Result: Lack of lifeline and return flowcontrol

Screenshot:

Screenshot 2024-04-19 at 5.21.51 PM.pngScreenshot 2024-04-19 at 5.21.51 PM.png

nus-se-script commented 2 months ago

Team's Response

"has no lifeline at Storage", there is a lifeline present at Storage? It is shown as the dotted line.

"lack a return of flow control back to the FAP class": The return arrows, as well as the activation bar are omitted as the specifics of the storage method sequence is not the main focus of our diagram. Also, the method returns a void value. The "Control flow" is still accurate when reading from the top to the bottom.

From the textbook: image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]