JustinSoh / pe

0 stars 0 forks source link

Should not be able to add Modules of equivalent status (CS2113T and CS2103) #2

Open JustinSoh opened 2 months ago

JustinSoh commented 2 months ago

Description: The app should not allow me to add CS2113T and CS2103 as they are modules that cannot be taken at the same time. This is because they fufil the same requirement.

Steps to Reproduce:

  1. Launch the app
  2. add c/CS2113t w/4
  3. add c/CS2103 w/4

Actual Result: Allows me to add both courses even though technically I could never do both of these courses together

Screenshot:

image.png

soc-pe-bot commented 2 months ago

Team's Response

We chose not to implement preclusion prevention in our project due to inconsistent formatting of preclusion strings in the data from the NUSmods JSON file. While recognizing that this feature could be beneficial, it was ultimately excluded from our project's scope. The complexity of development is further heightened by NUS's policy allowing students to enroll in modules that are preclusions of each other. Although this practice is strongly discouraged and usually results in no modular credits being awarded, the limited development timeframe rendered the feature impractical and outside the project's scope..

Also, it does not affect the product's regular operation as the user is allowed to remove any precluded modules.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: However, as a user, I wouldn't know beforehand that these two are precluded modules and may plan my mods in a way where I am taking equivalent courses. This fails the use case of Student users adding modules that they have taken or plan to take

Additionally, the UG didn't mention that this feature is not supported.

image.png


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]