search

JustinSoh / pe

0 stars 0 forks source link

Starting out GPA should show 5.0 rather then 0 #4

Open JustinSoh opened 2 months ago

JustinSoh commented 2 months ago

Description: When I only have a Zero MC module, my GPA should always start out at 5.0 and not 0.

Steps to Reproduce:

  1. Launch the app
  2. Add a Zero MC mod add c/ES1000
  3. gpa

Expected Result: It should show that my GPA is 5.0 as I have zero MCs so far and my Cap always starts out with 5

Actual Result: Prints No countable grades present to tally

Screenshot:

image.png

soc-pe-bot commented 2 months ago

Team's Response

image.png

Under the NUS website, it is mentioned that courses with no assigned unit will be excluded from calculation of GPA. Thus, it will actually be wrong to say you even have a GPA when you have only inputted a 0 MC course. Output of "No countable grades present to tally." does not mean that your GPA is 0, but rather you do not have any courses that contributes to your GPA.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]