Should not be possible to finish so many MCs in one semester

[JustinSoh]

Description: There should be a cap on the amount of MCs I can take in a given semester. In this case, I was able to add up to 122 MCs in one semester. I did this by modifying the txt file and adding in valid semesters

Steps to Reproduce:

1. Launch the app
2. Add all the valid classes in the txt file stored under the data folder
3. Use view to see that I aim to complete 122MCs in one semester

Expected Result: There should be a warning or error which limits me from adding that many MCs in a given semester

Actual Result: I am able to add all of it

Screenshot:

[nus-pe-bot]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

GPA can affect maximum Mcs taken

if my GPA is below a certain value, I'm not allowed to overload in current semester.

CEG Study Plan for: Fu Xueer
_____________________________________________________________
| Y1S1 [Sem 1] | Y1S2 [Sem 2] | Y2S1 [Sem 3] | Y2S2 [Sem 4] |
|ES2631      F |              |CG1111A       |              |
|CS1010        |              |LAJ1201       |              |
|GEA1000       |              |LAJ2201       |              |
|DTK1234       |              |LAJ2202       |              |
|EG1311        |              |              |              |
|IE2141        |              |              |              |
|EE2211        |              |              |              |
|CDE2501       |              |              |              |
|CDE2000       |              |              |              |
|PF1101        |              |              |              |
|CP3880        |              |              |              |
|CS2040C       |              |              |              |
_____________________________________________________________
| Y3S1 [Sem 5] | Y3S2 [Sem 6] | Y4S1 [Sem 7] | Y4S2 [Sem 8] |
_____________________________________________________________
- Current Study: Semester 8
- Total MCs taken: 72.00 / 160
- Total MCs listed: 72.00 / 160
_____________________________________________________________
gpa
_____________________________________________________________
Your current GPA is: 0.00
_____________________________________________________________

can consider implementing this feature.

---

_{[original: nus-cs2113-AY2324S2/pe-interim#1277] [original labels: severity.Low type.FeatureFlaw]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We did not account for this as there are multiple conditions, limitations and exceptions that each student can request to their home faculty that can affect their maximum or minimum workload. Even if the user's GPA is not high enough, if he can provide a valid reason to home faculty, he could still get a maximum workload waiver. Given that users are able to apply for maximum workload waiver and it is subject to the faculty's approval (there is even precedence of 40MCs in 1 semester), we do not restrict the number of modules a user can add in a semester, leaving up to the users discretion to keep track of the number of modules they add to each semester. This is also the design choice done by nusmods, where they do not restrict the amount of mods one can add when planning for a semester. Therefore based on the aforementioned reasons, this issue is rejected.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• [x] I disagree

Reason for disagreement: As per the response above, the reason quoted above is about overloading. Mine is regarding the fact that you can add more then the maximum workload waiver.

---

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** As quoted in the reply, I do not believe that there is a workload waiver that allows one to do 122 MCs in a semester. To the point of this being a design choice by NUSMods, I believe that FAP and NUSMods are two different applications. As a user of FAP, I may not know very well what the limitations are and would like to get additional warnings/help on some of the boundaries. I agree that there are multiple scenarios to consider, but as a user - I would prefer it if there were a warning when I add more modules than the recommended workload of 20mcs a semester. I believe that would be helpful to the users of FAP as they might miscalculate the modules that they have taken.

---

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]

---

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]

---