JustinSoh / pe

0 stars 0 forks source link

Bug in the Graduation Requirement having done a module that is considered equivalent #6

Open JustinSoh opened 5 months ago

JustinSoh commented 5 months ago

Description: After adding all the modules that I have done, and typing the graduate requirement - I see that I am asked to do CS1231 even though I have already completed CS1231S which are equivalent

Steps to Reproduce:

  1. Open the data file and paste this in
    InitialisedUser 2 justin
    ES1000 A+ 1 true
    CS2040C A+ 1 true
    CS2113T A+ 1 true
    CS2040 A+ 1 true
    CS2101 A+ 1 true
    CS2103 A+ 1 true
    LAF1201 A+ 1 true
    ES1103 A+ 1 true
    IS4231 A+ 1 true
    CS1231S A+ 1 true
    ES2631 A+ 1 true
    CS1010 A+ 1 true
    GEA1000 A+ 1 true
    EG1311 A+ 1 true
    IE2141 A+ 1 true
    CDE2501 A+ 1 true
    CG4002 A+ 1 true
    MA1512 A+ 1 true
    MA1301 A+ 1 true
    CP3880 CS 1 true
    CG1111A A+ 1 true
    CG2023 A+ 1 true
    EE4204 A+ 1 true
    EE2026 A+ 1 true
    CS2106 A+ 1 true
    CS2103 A+ 1 true
    CS2104 A+ 1 true
    CS2105 A+ 1 true
    CS2107 A+ 1 true
    GEX1000 A+ 1 true
    GEX1000T A+ 1 true
    GEX1001 A+ 1 true
    GEX1004 A+ 1 true
    GEX1005 A+ 1 true
    GEX1007 A+ 1 true
    GEX1007T A+ 1 true
    GEX1009 A+ 1 true
    GEX1009T A+ 1 true
    GEX1010 A+ 1 true
    DTK1234 A+ 1 true
    EE2211 A+ 1 true
    CDE2000 A+ 1 true
    PF1101 A+ 1 true
    MA1511 A+ 1 true
    MA1508E A+ 1 true
    EG2401A A+ 1 true
    CG2111A A+ 1 true
  2. Launch the app
  3. Run graduate
  4. Run view Expected Result: CS1231 is no longer there as I have cleared an equivalent mod before

Actual Result: CS1231 still shows up despite me clearing CS1231S already

Screenshot:

image.png

soc-se-bot commented 5 months ago

Team's Response

While we acknowledge that adding cross-listed/overlapping modules does not update the graduate list for the current iteration of the application, it is not a type.FunctionalityBug as it is expected and should not be classified as severity.High.

By definition, a bug classified as severity.High should be "a problem that affects most users" and "problems that make the product almost unusable for most users". We do not believe that the inability of adding a cross-listed/overlapping module makes the product unusable for most users since we argue that:

  1. Users can just add its equivalent that exists in the CEGModule list.
  2. The event of having a CEG student taking a cross-listed/overlapping module is slim, hence those students are a minority compared to students taking the recommended ones listed here. Refer to the image attached below regarding reading cross-listed/overlapping modules from the NUS UG FAQ.

image.png

Hence we believe that the appropriate severity should be severity.Low since it may "appear in very rare situations and causes minor inconvenience only" in the event a CEG student chooses to read an overlapping course. It does not affect normal operations of the product.

Items for the Tester to Verify

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.High`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]