JustinTimperio / pacback

Advanced Version Control for Arch Linux
MIT License
148 stars 4 forks source link

Automatic sudo is not handled correctly #19

Closed Gr3q closed 4 years ago

Gr3q commented 4 years ago

Describe the Bug:\ If pacback has started without sudo, sudo is asking for password, but pacback still throws the error that it must be ran as sudo

Output of Command



**Machine (please fill in the following information):**
 - Kernel Version: Linux gr3q-desktop 5.4.11-arch1-1 #1 SMP PREEMPT Sun, 12 Jan 2020 12:15:27 +0000 x86_64 GNU/Linux
 - Python Version: Python 3.8.1
 - Install Type: pacback
 - Pacback Version: Pacback Version: 1.6.1

**To Reproduce**
Steps to reproduce the behavior:
1. Run any pacback command without sudo with user account
2. Enter password
3. Observe

**Expected behavior**
The sudo should have been picked up by pacback
JustinTimperio commented 4 years ago

So I noticed this myself but have still been unable to trace which command is actually asking for sudo. I think it may be the way I am checking to see if the command is executed as root.

JustinTimperio commented 4 years ago

I apologize for the slow response here. Been on the road traveling so I haven't had the time to look at this fully. So this was actually a very simple issue. Sudo was being rasied to write the error out to a log in /var. I'm going to remove this feature and push it downstream along with some other patches in V1.7.

Gr3q commented 4 years ago

Thats ok, there is no need to to patch just for me, I can wait.

JustinTimperio commented 4 years ago

This has not been forgotten! This will be fixed in the full release which has a session management system that will handle these errors.

JustinTimperio commented 4 years ago

This bug can finally be squashed