Simplify travis builds - Githubissues

JustinTulloss / zeromq.node

Node.js bindings to the zeromq library

MIT License

1.65k stars 286 forks source link

Simplify travis builds #569

Closed lgeiger closed 7 years ago

lgeiger commented 7 years ago

This PR is based on #565

zeromq will be built without libsodium to speed up the builds even more. I made a new PR for this because it changes the zeromq versions.

lgeiger commented 7 years ago

It looks like the tests error (Error: Address already in use) more often than with the old build. This could be an issue with the tests. Since the old build worked fine let's stick to that.

rgbkrk commented 7 years ago

On latest libzmq release, you don't even need libsodium. Tweetnacl is built in. /cc @minrk

minrk commented 7 years ago

Details: libzmq 4.1.5 adds bundled tweetnacl, and I believe it is used by default (check configure output to be sure).