JustinTulloss / zeromq.node

Node.js bindings to the zeromq library
MIT License
1.65k stars 286 forks source link

Support for building zeromq with yarn instead of npm #592

Closed sohailalam2 closed 7 years ago

sohailalam2 commented 7 years ago

I have a custom docker image of NodeJs 7.7.1 without NPM package manager instead, there is Yarn. While installing zeromq in the container, it failed with the following error message -

error /tmp/app/node_modules/zeromq: Command failed.
Exit code: 127
Command: sh
Arguments: -c prebuild-install || (npm run build:libzmq && node-gyp rebuild)
Directory: /tmp/app/node_modules/zeromq
Output:
prebuild-install info begin Prebuild-install version 2.1.2
prebuild-install info looking for local prebuild @ prebuilds/zeromq-v4.2.1-node-v51-linux-x64.tar.gz
prebuild-install info npm cache directory missing, creating it...
prebuild-install info looking for cached prebuild @ /root/.npm/_prebuilds/https-github.com-zeromq-zeromq.js-releases-download-v4.2.1-zeromq-v4.2.1-node-v51-linux-x64.tar.gz
prebuild-install http request GET https://github.com/zeromq/zeromq.js/releases/download/v4.2.1/zeromq-v4.2.1-node-v51-linux-x64.tar.gz
prebuild-install http 200 https://github.com/zeromq/zeromq.js/releases/download/v4.2.1/zeromq-v4.2.1-node-v51-linux-x64.tar.gz
prebuild-install info downloading to @ /root/.npm/_prebuilds/https-github.com-zeromq-zeromq.js-releases-download-v4.2.1-zeromq-v4.2.1-node-v51-linux-x64.tar.gz.34-018f5a3dd1c5c.tmp
prebuild-install info renaming to @ /root/.npm/_prebuilds/https-github.com-zeromq-zeromq.js-releases-download-v4.2.1-zeromq-v4.2.1-node-v51-linux-x64.tar.gz
prebuild-install info unpacking @ /root/.npm/_prebuilds/https-github.com-zeromq-zeromq.js-releases-download-v4.2.1-zeromq-v4.2.1-node-v51-linux-x64.tar.gz
prebuild-install info unpack resolved to /tmp/app/node_modules/zeromq/build/Release/zmq.node
prebuild-install WARN install Dynamic loading not supported
sh: npm: not found
The command '/bin/sh -c yarn' returned a non-zero code: 1
rgbkrk commented 7 years ago

https://github.com/zeromq/zeromq.js is compatible with yarn, same API

sohailalam2 commented 7 years ago

@rgbkrk actually this was a mistake. The above issue is for https://github.com/zeromq/zeromq.js and not for this library. I don't know how I managed to put it as an issue here. My apologies :(

rgbkrk commented 7 years ago

Whoops! I stand corrected and will have to investigate over there.