search

JustinVoitel / svelte-hero-icons

Heroicons for SvelteKit (Project based on heroicons)
MIT License
118 stars 7 forks source link

README advice for Windows developers applies to Mac pnpm users as well #11

Closed brunobely closed 2 years ago

brunobely commented 2 years ago

Just switched a project to use pnpm and found that adding this package to noExternal within Vite's config solves the following issue. Thought it might be worth adding to the README:)

11:35:38 PM [vite] Error when evaluating SSR module /src/lib/features_highlights/FeaturesHighlights.svelte:
TypeError [ERR_UNKNOWN_FILE_EXTENSION]: Unknown file extension ".json" for /[project_path]/node_modules/.pnpm/svelte-hero-icons@3.0.0/node_modules/svelte-hero-icons/heroicons/AcademicCap.json
    at new NodeError (node:internal/errors:371:5)
    at Object.file: (node:internal/modules/esm/get_format:72:15)
    at defaultGetFormat (node:internal/modules/esm/get_format:85:38)
    at defaultLoad (node:internal/modules/esm/load:13:42)
    at ESMLoader.load (node:internal/modules/esm/loader:303:26)
    at ESMLoader.moduleProvider (node:internal/modules/esm/loader:230:58)
    at new ModuleJob (node:internal/modules/esm/module_job:63:26)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:244:11)
    at async ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:78:21)
    at async Promise.all (index 0)
JustinVoitel commented 2 years ago

with the latest version of sveltekit every platform now needs to add noExternal to their config in order to use the package