search

JustinVoitel / svelte-hero-icons

Heroicons for SvelteKit (Project based on heroicons)
MIT License
118 stars 7 forks source link

remove default classes #17

Closed Cassolette closed 2 years ago

Cassolette commented 2 years ago

These are common and generic class names that may collide with existing names.

Tailwind CSS for example provides an outline class to add outlines, causing this unwanted styling. image image

Note: This will be a breaking change for those who intentionally styled their icons using the removed classes.

An alternative option would be to rename these classes to something less generic like svelte-hero-icons-outline, though I would very much rather have full control over the icon classes.

JustinVoitel commented 2 years ago

@Cassolette Will merge and release it under 4.0.0 after the holidays! I thought it would be a good idea without tailwind in mind ^^

If you want you can check out @steeze-ui/icons, where you already have full control over the classes.

Cassolette commented 2 years ago

It's all good, take your time 👍

If you want you can check out @steeze-ui/icons, where you already have full control over the classes.

Very nice, will check that out! I assume that is the intended successor to svelte-hero-icons?

JustinVoitel commented 2 years ago

implemented in 4.0.1! Sorry I forgot to merge it 😅