Justineo / vue-clamp

Clamping multiline text with ease.
https://vue-clamp.vercel.app
MIT License
699 stars 89 forks source link

Add ssr support #33

Closed Sharsie closed 4 years ago

Sharsie commented 4 years ago

Because the original author of the PR https://github.com/Justineo/vue-clamp/pull/28 made none of the requested changes, here's another PR - I briefly tested it, it does the same thing as the other PR, but introduces changes requested by @Justineo Also fixes #31

Mdev303 commented 4 years ago

I just tried it , and im still getting the error : The client-side rendered virtual DOM tree is not matching server-rendered content. This is likely caused by incorrect HTML markup, for example nesting block-level elements inside <p>, or missing <tbody>. Bailing hydration and performing full client-side render.

Sharsie commented 4 years ago

@MaazDev Can you provide me with the content you are passing into it? We've been using it for more than a month without any problems so far. But I cannot tell for sure if it supports more than just plaintext

Mdev303 commented 4 years ago

My bad , i have to use the tag props to use it as a paragraph sorry , works fine :)

voraczech commented 4 years ago

Is there a chance to merge this? @Justineo @rndmerle @arnaudvalle

arnaudvalle commented 4 years ago

@voraczech sorry, I don't have any rights on this repo

akagamina commented 4 years ago

I think @Justineo were dead