Overhaul Logging to use Python Logging Package

Justintime50 / github-archive

A powerful tool to concurrently clone, pull, or fork user and org repos and gists to create a GitHub archive.

MIT License

186 stars 48 forks source link

Overhaul Logging to use Python Logging Package #12

Closed Justintime50 closed 3 years ago

Justintime50 commented 3 years ago

This project is currently using a home grown logger, instead we should be using the logging package and roll-over old logs.

Acceptance Criteria

[x] Items are logged to console instead of printed with the appropriate logging level for the type of message it is
[x] Logged messages are successfully saved to a file
[x] Old log files are rolled over to conserve disk space
[x] Log file names play nicely with all OS's (Windows especially)

ghost commented 3 years ago

I see error while running on windows. Logger is using an invalid filename with ":" char.

debug_image2

debug_image3

Justintime50 commented 3 years ago

Windows is so difficult...

Thanks for submitting this too! I'll make sure the filename conforms to the Windows filename schema as I overhaul logging here soon.

Justintime50 commented 3 years ago

@GonistLelatel I apologize for the delay on this, thanks for your patience! I've merged in v3.0.0 which fixes this log name issue on Windows along with various other items. Please don't hesitate to reach out if you find more items that need to be addressed. Thanks again for taking the time to report this!