Justintime50 / harvey

The lightweight Docker Compose deployment runner.
https://github.com/Justintime50/harvey-ui
MIT License
13 stars 3 forks source link

Deployment Hashes Need an Attempt Appended #74

Closed Justintime50 closed 1 year ago

Justintime50 commented 1 year ago

We currently cheat on generating unique deployment hashes by reusing the commit hash, the problem is you can technically have multiple deployments of a single commit if you have GitHub Actions redo the action/deploy or eventually when you click the "redeploy" button on the UI. We should have an attempt number associated so that we don't blow away the logs of a previous attempt of the same commit being deployed (in my usage, I do this frequently, mainly while developing and a deploy fails).

Justintime50 commented 1 year ago

Fixed via https://github.com/Justintime50/harvey/commit/9adbcce53fff98c85e1784e349096f46b3ca6584