JustusAdam / justusadam.github.io

Sources for my website
justus.science
Other
2 stars 6 forks source link

Making the HTML valide #3

Closed MarauderXtreme closed 9 years ago

MarauderXtreme commented 9 years ago

I've seen that you use image instead of img for 2 of your pictures in the site. I corrected it and included an alt attribute.

JustusAdam commented 9 years ago

Oh good. I had no idea that was incorrect.

I slightly dislike that merge commit but I'll merge it regardless.

As for the alt text for the page logo, wouldn't it be better to say "Page logo" or just "Logo" instead of "Justus Science Logo"?

MarauderXtreme commented 9 years ago

I don't know why I had to merge but git told me it was neccessary. I'm too not satisfied with it.

Well the alt attribute get's displayed if the images can't be loaded. You can now decide what is better to read in the header. Page Logo or Justus Science Logo.

JustusAdam commented 9 years ago

I know. I would have though "Page logo" is better.

MarauderXtreme commented 9 years ago

I don't care. You can change it to what you like. Only include it.