search

JustusAdam / language-haskell

Highlighting support for the Haskell language in visual studio code.
https://marketplace.visualstudio.com/items/justusadam.language-haskell
BSD 3-Clause "New" or "Revised" License
96 stars 48 forks source link

Alex and Happy highlighting #188

Closed sloane-shark closed 3 years ago

sloane-shark commented 3 years ago

Should fix #97. I whipped up the Alex grammar some time back but only used it locally, and I wanted to find a way to make these more useful to other people. I'm happy to clean them up, change anything to fit the standards of the repo, add more scopes/matches, whatever. Added a test case for each.

sheaf commented 3 years ago

@matthewess Many thanks for your contribution. I'll take a closer look tomorrow, but this looks excellent.

sloane-shark commented 3 years ago

@sheaf I think I addressed most or all of the feedback you raised. I really appreciate all of it, because I don't have a ton of experience with any of Alex, Happy, or TextMate grammars. On that note, please feel free to offer more suggestions or tweaks for making this as high quality as possible, I think we're close!

Side note: I was unaware of vscode-tmlanguage-test before now, but it makes the whole development process SO much easier than the TextMate grammar debugger that's built in to vscode.

sheaf commented 3 years ago

Excellent, thanks for your work.