Often we want to supply maxiter and tol. This is already possible right now by passing in a custom Lanczos()/Arnoldi() but this feels a bit clunky (mostly because the orthonormalizer isn't an optional named parameter):
eigsolve(fun,startvec,Lanczos(KrylovKit.ImplicitRestart(maxiter),KrylovKit.Defaults.orth,tol=tol)))
The change in this proposal allows to pass maxiter/tol to eigsolve, but perhaps it would be better to change/supply another constructor for Lanczos, allowing
eigsolve(fun,startvec,Lanczos(ImplicitRestart(maxiter),tol=tol)) ?
Jutho
commented
6 years ago
Often we want to supply maxiter and tol. This is already possible right now by passing in a custom Lanczos()/Arnoldi() but this feels a bit clunky (mostly because the orthonormalizer isn't an optional named parameter): eigsolve(fun,startvec,Lanczos(KrylovKit.ImplicitRestart(maxiter),KrylovKit.Defaults.orth,tol=tol)))
The change in this proposal allows to pass maxiter/tol to eigsolve, but perhaps it would be better to change/supply another constructor for Lanczos, allowing eigsolve(fun,startvec,Lanczos(ImplicitRestart(maxiter),tol=tol)) ?