Jutho / KrylovKit.jl

Krylov methods for linear problems, eigenvalues, singular values and matrix functions
Other
284 stars 37 forks source link

Heads up about test error on 1.3 #21

Closed KristofferC closed 4 years ago

KristofferC commented 5 years ago

When testing this package against the upcoming 1.3 release, the following test error occured:

Error During Test at /root/.julia/packages/KrylovKit/kSkwM/test/linalg.jl:57
  Got exception outside of a @test
  MethodError: no method matching hschur!(::UpperHessenberg{Float32,Array{Float32,2}})
  ...
  Stacktrace:
   [1] top-level scope at /root/.julia/packages/KrylovKit/kSkwM/test/linalg.jl:61
   [2] top-level scope at /workspace/srcdir/julia/usr/share/julia/stdlib/v1.3/Test/src/Test.jl:1180
   [3] top-level scope at /root/.julia/packages/KrylovKit/kSkwM/test/linalg.jl:57
   [4] top-level scope at /workspace/srcdir/julia/usr/share/julia/stdlib/v1.3/Test/src/Test.jl:1107
   [5] top-level scope at /root/.julia/packages/KrylovKit/kSkwM/test/linalg.jl:57
   [6] include at ./boot.jl:328 [inlined]
   [7] include_relative(::Module, ::String) at ./loading.jl:1105
   [8] include(::Module, ::String) at ./Base.jl:31
   [9] include(::String) at ./client.jl:432
   [10] top-level scope at /root/.julia/packages/KrylovKit/kSkwM/test/runtests.jl:19
   [11] include at ./boot.jl:328 [inlined]
   [12] include_relative(::Module, ::String) at ./loading.jl:1105
   [13] include(::Module, ::String) at ./Base.jl:31
   [14] include(::String) at ./client.jl:432
   [15] top-level scope at none:6
   [16] eval(::Module, ::Any) at ./boot.jl:330
   [17] exec_options(::Base.JLOptions) at ./client.jl:271
   [18] _start() at ./client.jl:468

This is likely due to the PR https://github.com/JuliaLang/julia/pull/31853 introducing the new UpperHessenberg type returned from some functions. Adding a specialization here might be enough to fix it.

Jutho commented 5 years ago

Thanks; that's easily fixed but now I run up against a bug in julia master, which I reported in this existing thread:

https://github.com/JuliaLang/julia/issues/33105