Closed lkdvos closed 5 months ago
Attention: Patch coverage is 86.13139%
with 19 lines
in your changes are missing coverage. Please review.
Project coverage is 82.34%. Comparing base (
68b3baf
) to head (bdf7a97
). Report is 1 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
ext/KrylovKitChainRulesCoreExt/eigsolve.jl | 85.71% | 19 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for starting this. I would also still like to experiment with my alternative solution for doing eigsolve AD, which itself uses eigsolve instead of linsolve.
I think in any case we should look for a solution to determine how the rrule
is computed, even just changing the tolerances should be accessible.
Also, I think @pbrehmer has an implementation for the svdsolve
, so I'll tag him here :)
This moves the AD rules into a package extension. The implementation for
linsolve
comes from the current master The implementation foreigsolve
comes from one of the open PRs (#56 )TODO
svdsolve
AD rulesexpsolve
AD rules