search

Jutho / StridedViews.jl

A Julia package to represent strided views over a parent DenseArray
MIT License
6 stars 2 forks source link

Add `isstrided` trait #10

Closed Jutho closed 4 months ago

Jutho commented 4 months ago

This can be used to check whether an AbstractArray instance can be converted to a StridedView.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.27%. Comparing base (8b69aa9) to head (badb43b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10 +/- ## ========================================== + Coverage 93.71% 94.27% +0.55% ========================================== Files 4 4 Lines 175 192 +17 ========================================== + Hits 164 181 +17 Misses 11 11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jutho commented 4 months ago

Yes, that should be easier now that the error changed from the strides calculation to the sreshape function itself. Before this was harder, because it was thrown at a certain stage of the recursive process to calculate the strides, so it did no longer have access the full old and new sizes.