search

Jutho / TensorKit.jl

A Julia package for large-scale tensor computations, with a hint of category theory
MIT License
218 stars 38 forks source link

braidingtensor special cases #56

Closed maartenvd closed 3 years ago

maartenvd commented 3 years ago

some special cases for the braidingtensor action (+ some braidingtensor bugfixes)

also includes special case code for artin_braid, when the leg that is being braided is trivial.

Jutho commented 3 years ago

Thanks; there were still quite a few bugs in my part apparently :-)

maartenvd commented 3 years ago

How would you avoid the inference failures in artin_braid?

codecov[bot] commented 3 years ago

Codecov Report

Merging #56 (b5e7ef5) into master (1499f08) will decrease coverage by 3.06%. The diff coverage is 8.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   71.02%   67.95%   -3.07%     
==========================================
  Files          34       34              
  Lines        4224     4441     +217     
==========================================
+ Hits         3000     3018      +18     
- Misses       1224     1423     +199
Impacted Files Coverage Δ
src/tensors/braidingtensor.jl 0.00% <0.00%> (ø)
src/tensors/planar.jl 0.00% <0.00%> (ø)
src/fusiontrees/manipulations.jl 93.77% <95.23%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1499f08...b5e7ef5. Read the comment docs.

Jutho commented 3 years ago

Hi Maarten; I did not have the time to review in detail the contraction code and the resolution of resolving all taus by @planar2, but a loop is also what I thought. I will merge so that you can continue while I am gone.

maartenvd commented 3 years ago

ah, unfortunately I still had an unpushed commit, containing another special case where scalars did not play well with planar, but also a bugfix for some special case braidingtensor actions. It should be the last of it, as I now have a fully planar copy of mpskit, which I guess is a fairly extensive test.

In any case, I don't particularly mind working with a forked copy of tensorkit for the time being - enjoy your holiday first and foremost!