search

Jutho / TensorKit.jl

A Julia package for large-scale tensor computations, with a hint of category theory
MIT License
234 stars 41 forks source link

Small fixes #98

Closed lkdvos closed 10 months ago

lkdvos commented 10 months ago
codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6fb9d67) 80.39% compared to head (5fdd659) 80.57%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #98 +/- ## ========================================== + Coverage 80.39% 80.57% +0.18% ========================================== Files 42 42 Lines 5432 5453 +21 ========================================== + Hits 4367 4394 +27 + Misses 1065 1059 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jutho commented 10 months ago

Looks good, although it seems one AD test still did not pass on Julia 1.6. But it seems an accuracy issue again, at least all the values that are printed seem to match with a large number of significant digits.

lkdvos commented 10 months ago

I'll keep playing around a bit to see if I can get it to behave, it's probably not that important, but the green check is nice

Jutho commented 10 months ago

Especially since this will affect all further CI runs once merged.

Jutho commented 10 months ago

Ok I'll merge this and revert Project.toml changes in the final commits to #95