Add Base.zero, Grassmann.invretract, and Grassmann.matchgauge

Jutho / TensorKitManifolds.jl

Useful tools for working with isometric or unitary tensors

MIT License

19 stars 6 forks source link

Add Base.zero, Grassmann.invretract, and Grassmann.matchgauge #5

Closed mhauru closed 4 years ago

mhauru commented 4 years ago

I also ended up removing the global invretract since I think it should be specific to Stiefel/Grassmann/Unitary, just like e.g. project. I guess that makes this a breaking change, at least in principle.

Also, I tried adding a test for Stiefel.invretract too, but it errored in _stiefellog with AssertionError: mapreduce(abs ∘ imag, max, logU; init = abs(zero(eltype(logU)))) <= tol I could look into this, but maybe you know what's going on already?

Jutho commented 4 years ago

Not sure what is going on with invretract but it also seems to be untested.

This looks good so I will merge it as is, and maybe then go through the code again and also fix/ add tests for Stiefel.invretract.