Juuxel / Adorn

A decoration mod for Minecraft 1.14+.
https://www.curseforge.com/minecraft/mc-mods/adorn
MIT License
93 stars 30 forks source link

[Fabric] Colormatic (custom color for ressource pack) broken by Adorn #305

Closed ksorah1 closed 1 year ago

ksorah1 commented 1 year ago

Adorn version

Adorn 3.8.1 for 1.19.2

Minecraft version

1.19.2

Mod loader

Fabric

Mod loader version

fabric-api-0.72.0+1.19.2, 0.14.14 loader

Describe the bug

Carpets are white instead of red, with the mod installed.

To reproduce

Without Adorn I use Colormatic to get the "custom colors" features like Optifine but for fabric, and to get colored items (carpets for exemple), and biomes, with texturepacks like Patrix, that use this feature.

When I use Adorn, Colormatic is not working anymore, carpets are white.

It's not from fabric-language-kotlin-1.9.1+kotlin.1.8.10 (I tried it alone and all is working).

Game logs

No response

Additional context

No response

ksorah1 commented 1 year ago

I addition, I can say that your furnitures are colored.

Vanilla red carpet : 2023-02-27 20_35_44-Minecraft_ 1 19 2 - Singleplayer 2023-02-27 20_38_31-Minecraft_ 1 19 2 - Singleplayer

Your pink sofa : 2023-02-27 20_35_53-Minecraft_ 1 19 2 - Singleplayer

ksorah1 commented 1 year ago

The red bed is working too.

ksorah1 commented 1 year ago

Also I'm looking for somewhere to get the recipes, I don't find the brewing machine and the trading table anywhere.

Juuxel commented 1 year ago

You can find their recipes using the vanilla recipe book if you've found the ingredients, or with a recipe viewer such as EMI or REI.

You can also see the brewer's brewing recipes using either of those mods - Adorn supports both.

ksorah1 commented 1 year ago

Thank you for your answer, I won't use EMI or REI because I wan't to keep my vanilla experience.

RIP.

What about the carpets ?

Juuxel commented 1 year ago

I can't reproduce this issue with Adorn + Colormatic + Iris + Patrix resource pack + Arc shader pack:

Are you sure you have no other mods affecting the rendering? Adorn shouldn't have any effect, actually.

ksorah1 commented 1 year ago

Damn, I use those mods (the minimum) : 2023-02-27 22_27_54-FenĂȘtre console de 1 19 2 fabric - MultiMC 5 I'm not actualy at home, I can't test more for now.

Sorry for the problem.

ksorah1 commented 1 year ago

Now I'm at home but I don't know what I can try to turn it off, an idea ?

Juuxel commented 1 year ago

I'm not 100% sure, but try disabling Continuity since the resource pack also has connected textures for carpet. Those two features might interfere in this case.

ksorah1 commented 1 year ago

You are right, that's continuity, the problem is that I need it or my game will be ugly : 2023-02-27 23_05_55-Minecraft_ 1 19 2 - Singleplayer 2023-02-27 23_05_43-Minecraft_ 1 19 2 - Singleplayer

With continuity : 2023-02-27 23_09_29-Minecraft_ 1 19 2 - Singleplayer

Juuxel commented 1 year ago

Not sure what could help then since this isn't related to Adorn at all. Maybe try asking from the authors of Colormatic/Continuity?

ksorah1 commented 1 year ago

Yes but the problem happen only if I use Adorn.

Juuxel commented 1 year ago

I did some further investigation, and this can be reproduced without Adorn installed pretty easily by having a resource pack that contains a blockstates file where minecraft:block/red_carpet (for example) is used in a multipart definition.

TestPack.zip

This pack reproduces the issue without Adorn, so it's not a bug in Adorn - just triggered by Adorn's (perfectly normal) block models.

Juuxel commented 1 year ago

This might be a case of kvverti/colormatic#84.

ksorah1 commented 1 year ago

Arf and you sent them the link, thank you !

ksorah1 commented 1 year ago

The guy just don't care, are you sure the problem is from his mod ?

Juuxel commented 1 year ago

Yes. It's mostly coincidentally present when Adorn is used since Adorn has some block models for its blocks that use the carpet models. The exact same thing can be caused by a resource pack. It's not something I can fix.

ksorah1 commented 1 year ago

Ok thank you.