search

JuyeoungJun / cron-monitoring

for cron-monitoring
0 stars 0 forks source link

Resolve "크론 서버 기능 개발" #48 - [merged] #101

Closed JuyeoungJun closed 3 years ago

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 16, 2021, 15:42

Merges feat/48-cron-server -> develop

Issue Number

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 16, 2021, 15:43

changed the description

JuyeoungJun commented 3 years ago

In GitLab by @gm1702816 on Jun 17, 2021, 10:14

changed title from Draft: Resolve "크론 서버 기능 개발" to Draft: Resolve "크론 서버 기능 개발"{+ #48+}

JuyeoungJun commented 3 years ago

In GitLab by @gm1702816 on Jun 17, 2021, 10:14

changed the description

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 18, 2021, 18:01

added 12 commits

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 21, 2021, 09:58

added 2 commits

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 21, 2021, 09:59

marked this merge request as ready

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 21, 2021, 09:59

changed the description

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 21, 2021, 10:00

changed the description

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 21, 2021, 10:00

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 21, 2021, 11:58

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 21, 2021, 12:03

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 21, 2021, 12:10

changed the description

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 21, 2021, 16:15

Commented on src/test/java/gabia/cronMonitoring/repositoryImpl/CronServerRepositoryImplTest.java line 37

em.persist로 변경하여 메서드 간섭을 줄이면 좋을 것 같습니다

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jun 21, 2021, 16:26

Commented on src/main/java/gabia/cronMonitoring/service/CronServerService.java line 40

Optional 에 관한 조사 더 필요

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 22, 2021, 11:08

Commented on src/main/java/gabia/cronMonitoring/service/CronServerService.java line 40

확인했습니다! !isEmpty() -> ifPresent(), isEmpty() -> orElseThrow() 로 변경했습니다.

참고자료

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 22, 2021, 11:17

Commented on src/test/java/gabia/cronMonitoring/repositoryImpl/CronServerRepositoryImplTest.java line 37

changed this line in version 6 of the diff

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 22, 2021, 11:18

Commented on src/main/java/gabia/cronMonitoring/service/CronServerService.java line 40

changed this line in version 6 of the diff

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 22, 2021, 11:18

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 22, 2021, 11:18

Commented on src/test/java/gabia/cronMonitoring/repositoryImpl/CronServerRepositoryImplTest.java line 37

해당부분 확인 및 변경했습니다!

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 22, 2021, 11:18

resolved all threads

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 22, 2021, 11:23

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jun 22, 2021, 11:26

approved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 22, 2021, 11:27

approved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 22, 2021, 11:29

approved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 22, 2021, 11:30

mentioned in commit 54e2b966c785c6d608256179e9e8f0d6d2fd221e