search

JuyeoungJun / cron-monitoring

for cron-monitoring
0 stars 0 forks source link

feat : team 기능 개발 - team/teamuser 구현, Jacoco TestCoverage 적용 - [merged] #113

Closed JuyeoungJun closed 3 years ago

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 28, 2021, 16:58

Merges feat/58-team-team -> feat/52-team

Issue Number

What?

  1. 팀 기능 - Team/TeamUser crud 구현
  2. Jacoco TestCoverage 적용

    Why?

    팀 기능 추가를 위해

    How?

    API spec & interface/class diagram 참조

    Testing?

    Repository/Service/Controller 단위테스트 Controller를 시작으로 통합테스트

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 28, 2021, 17:03

changed title from f{-ix: cron_job_process와 cron_job의 UUID 불일치 해결-} to f{+eat : team 기능 개발 - team/teamuser 구현, Jacoco TestCoverage 적용+}

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 28, 2021, 17:03

changed the description

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 28, 2021, 17:17

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 28, 2021, 18:06

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jun 29, 2021, 09:40

Commented on src/main/java/gabia/cronMonitoring/controller/CronJobController.java line 40

UUID를 String으로 변환해서 처리하는 이유가 있을까요?

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jun 29, 2021, 09:40

Commented on src/main/java/gabia/cronMonitoring/controller/TeamController.java line 48

request에 추가적으로 setTeamAccount를 하신 이유가 있으실까요?

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jun 29, 2021, 09:40

Commented on src/main/java/gabia/cronMonitoring/dto/TeamDTO.java line 24

@Data 어노테이션에는 @Getter, @Setter, @ToString, @EqualsAndHashCode, @RequiredArgsConstructor 이 포함되어있습니다. 명시적으로 보여주시게 되면 @Getter @Setter 이외에도 사용하는 어노테이션이 보여지면 좋을거 같습니다.

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jun 29, 2021, 09:40

Commented on src/main/java/gabia/cronMonitoring/service/TeamService.java line 53

Spring Data Jpa 에서 save는 생성과 업데이트를 동시에 하는 것으로 알고 있습니다. 따라서 이 상황에서 Team이 있는지 확인 하지 않고 생성을 하게 된다면 이미 존재하는 팀에 영향을 주는 문제가 생길 것 같아 확인하는 이미 존재하는 Team인지 확인하는 로직이 있어야 할 것 같습니다.

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 29, 2021, 10:42

approved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 29, 2021, 10:43

unapproved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 29, 2021, 10:43

marked this merge request as draft

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 29, 2021, 13:37

Commented on src/main/java/gabia/cronMonitoring/controller/CronJobController.java line 40

changed this line in version 4 of the diff

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 29, 2021, 13:37

Commented on src/main/java/gabia/cronMonitoring/controller/TeamController.java line 48

changed this line in version 4 of the diff

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 29, 2021, 13:37

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 29, 2021, 14:14

resolved all threads

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 29, 2021, 14:15

marked this merge request as ready

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 29, 2021, 14:15

approved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jun 29, 2021, 14:15

approved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 29, 2021, 14:16

mentioned in commit 80a1e1cc7ff4feca58d0b47745b4afd16842311e