search

JuyeoungJun / cron-monitoring

for cron-monitoring
0 stars 0 forks source link

feat: 알림 기능 개발 - [merged] #119

Closed JuyeoungJun closed 3 years ago

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 2, 2021, 17:22

Merges feat/64-notice -> develop

Resolves: #64

Issue Number

64

What?

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 2, 2021, 17:33

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 5, 2021, 09:58

approved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 5, 2021, 10:40

Commented on src/main/java/gabia/cronMonitoring/service/NoticeService.java line 116

혹시 ifPresent()를 사용하지 않으신 사유에 대해서 여쭤봐도 될까요?

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 5, 2021, 11:05

approved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 5, 2021, 14:01

Commented on src/main/java/gabia/cronMonitoring/service/NoticeService.java line 116

changed this line in version 3 of the diff

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 5, 2021, 14:01

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 5, 2021, 14:32

Commented on src/main/java/gabia/cronMonitoring/service/NoticeService.java line 116

처음에 status가 존재하는 경우와 안하는 경우에 따라 구분해서 로직을 구성하려고 저렇게 하였다가 변경되었습니다. ifPresent로 수정하겠습니다.

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 5, 2021, 14:32

resolved all threads

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 6, 2021, 13:04

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 6, 2021, 16:16

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 6, 2021, 17:36

added 3 commits

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 6, 2021, 17:48

mentioned in commit 116d8cb67a9ea45e0f513418506efefa64d02ad0