search

JuyeoungJun / cron-monitoring

for cron-monitoring
0 stars 0 forks source link

feat: refresh 토큰 추가 - [merged] #120

Closed JuyeoungJun closed 3 years ago

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 2, 2021, 17:29

Merges feat/61-security -> develop

Issue Number

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 2, 2021, 17:37

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 2, 2021, 17:47

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 5, 2021, 09:24

approved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 5, 2021, 09:59

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 5, 2021, 10:26

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 5, 2021, 11:41

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 5, 2021, 14:19

Commented on src/main/java/gabia/cronMonitoring/exception/auth/InvalidTokenException.java line 5

각 exception 에 대한 Http status 지정과 Test 코드 작성할 때 Exception 에 대한 테스트도 있으면 좋을 것 같습니다.
참고 : https://velog.io/@max9106/Spring-Boot-ExceptionHandler

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 5, 2021, 14:19

Commented on src/main/java/gabia/cronMonitoring/service/RefreshTokenService.java line 31

해당하는 방식으로 인증을 한다면 Access Token만을 가지고도 계속해서 새로운 Access Token을 발급 받을 수 있기 때문에 위험하지 않을까요?? 추가적인 로직이 필요할 것 같아요

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 5, 2021, 17:19

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 5, 2021, 17:48

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 5, 2021, 17:57

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 09:12

added 6 commits

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jul 6, 2021, 09:13

approved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 09:14

enabled an automatic merge when the pipeline for b493cd97dce854c6e823ab3404e508d78219b68e succeeds

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 09:14

canceled the automatic merge

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 09:15

enabled an automatic merge when the pipeline for b493cd97dce854c6e823ab3404e508d78219b68e succeeds

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 09:24

canceled the automatic merge

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 09:31

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 09:39

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 09:52

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 10:58

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 11:11

Commented on src/main/java/gabia/cronMonitoring/service/RefreshTokenService.java line 31

changed this line in version 15 of the diff

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 11:11

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 11:12

enabled an automatic merge when the pipeline for 0b86d8db1a298fc2445317bc5b3bf724c79bbbc3 succeeds

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 11:16

canceled the automatic merge

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 16:39

added 2 commits

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 16:51

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 17:21

Commented on src/main/java/gabia/cronMonitoring/exception/auth/InvalidTokenException.java line 5

해당 부분 확인하고 Exception Handler 추가했습니다.

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 17:22

Commented on src/main/java/gabia/cronMonitoring/service/RefreshTokenService.java line 31

인증시에 클라이언트에 Refresh 토큰을 발급하고 그러한 토큰으로 Access 토큰을 재발급받는 형태로 로직을 변경했습니다.

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 17:22

resolved all threads

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jul 6, 2021, 17:23

mentioned in commit 286c28952ea2c7c2ac24fd42f5297564401b7ede