search

JuyeoungJun / cron-monitoring

for cron-monitoring
0 stars 0 forks source link

Resolve "알림관련 엔티티 구현" - [merged] #96

Closed JuyeoungJun closed 3 years ago

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 11:42

Merges feat/43-notice-entity -> develop

Closes #43

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 11:48

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 11:53

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 13:04

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jun 14, 2021, 13:09

Commented on src/main/java/gabia/cronMonitoring/entity/Notice.java line 31

JoinColumn(name = "user_id") 가 되어야 할 것 같습니다.

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jun 14, 2021, 13:09

Commented on src/main/java/gabia/cronMonitoring/entity/Notice.java line 44

id column 이름 cron_job_id로 변경 부탁드립니다.

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 14, 2021, 13:11

Commented on src/main/java/gabia/cronMonitoring/entity/Notice.java line 44

최신 커밋 기준에서 수정되었습니다.

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 14, 2021, 13:11

approved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202985 on Jun 14, 2021, 13:12

Commented on src/main/java/gabia/cronMonitoring/entity/Notice.java line 44

확인했습니다. Good

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 13:13

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 13:13

Commented on src/main/java/gabia/cronMonitoring/entity/Notice.java line 44

전부확인했습니다

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 14, 2021, 13:24

resolved all threads

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 13:35

requested review from @gm2202985

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 13:35

requested review from @gm2202981 and removed review request for @gm2202985

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 13:35

requested review from @gm2202985 and removed review request for @gm2202981

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 13:35

requested review from @gm2202981 and removed review request for @gm2202985

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 14, 2021, 13:59

Commented on src/main/java/gabia/cronMonitoring/entity/Notice.java line 40

변수명에서 id는 빼는게 좋을것 같습니다.

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 14, 2021, 14:01

Commented on src/main/java/gabia/cronMonitoring/entity/Webhook.java line 27

Notice 엔티티랑 연결해주는게 좋을것 같습니다.

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 14:02

Commented on src/main/java/gabia/cronMonitoring/entity/Notice.java line 40

changed this line in version 5 of the diff

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 14:02

Commented on src/main/java/gabia/cronMonitoring/entity/Webhook.java line 27

changed this line in version 5 of the diff

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 14:02

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 14:03

added 1 commit

Compare with previous version

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 14:04

resolved all threads

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 14:05

marked this merge request as ready

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 14:05

approved this merge request

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 14:05

enabled an automatic merge when the pipeline for 66d370d9bd37fb08ba4e3b0c13486de4634f533e succeeds

JuyeoungJun commented 3 years ago

In GitLab by @gm2202981 on Jun 14, 2021, 14:06

canceled the automatic merge

JuyeoungJun commented 3 years ago

In GitLab by @gm2202983 on Jun 14, 2021, 14:06

mentioned in commit 08ad8e76849fcbd2634ab25a909d1c6f4313e2db