Resolve "크론 프로세스 기능 개발" #46 - [merged] #99

Closed JuyeoungJun closed 3 years ago

In GitLab by @gm2202985 on Jun 16, 2021, 13:41

Merges feat/46-cron-process -> develop

Closes #46

What?

크론 프로세스 기능 개발
Issue Number

46

Why?
크론 프로세스 기능 필요
How?
API 스펙 참조 후 필요한 API 개발
Testing?
Junit 사용하여 테스트 진행

In GitLab by @gm2202985 on Jun 16, 2021, 13:44

changed the description

In GitLab by @gm2202985 on Jun 16, 2021, 13:44

requested review from @gm2202985

In GitLab by @gm2202985 on Jun 17, 2021, 10:20

changed the description

In GitLab by @gm2202985 on Jun 17, 2021, 10:21

changed the description

In GitLab by @gm2202985 on Jun 17, 2021, 11:10

changed the description

In GitLab by @gm2202985 on Jun 18, 2021, 10:27

changed title from Draft: Resolve "크론 프로세스 기능 개발" to Draft: Resolve "크론 프로세스 기능 개발"{+ (+ #46 +)+}

In GitLab by @gm2202985 on Jun 18, 2021, 10:27

changed title from Draft: Resolve "크론 프로세스 기능 개발" {-(+-} #46{- +)-} to Draft: Resolve "크론 프로세스 기능 개발" #46

In GitLab by @gm2202985 on Jun 21, 2021, 09:55

added 14 commits

d6dbb93e - fix: cron_job_process와 cron_job의 UUID 불일치 해결
93c2fea3 - feat: CronProcessDto 추가
b6ff4a7a - feat: CronJob, CronProcess의 NotFoundException 추가
1af509b9 - feat: CronProcess Controller 계층 개발
b0fc854b - Feat: Cron Process Service Layer 개발
e30b4ae6 - test: Cron Process Service Test 개발
2629634d - refactor: Cron Process의 Exception Handler을 ControllerExceptionHandler로 이동
89c85de8 - test: Cron Process Controller Test 구현
564d471c - feat: Cron Process Repository 구현
d45e9584 - feat: CronProcess Entity Builder 적용 및 Setter 삭제
0f18bdae - chore: Service Layer @Transactional 추가
bc65e971 - test: Cron process repository 테스트 구현
c2e4bf35 - refactor: 불필요한 주석 및 라이브러리 제거
dfa956ff - refactor: Cron Service 불필요한 parameter 제거

Compare with previous version

In GitLab by @gm2202985 on Jun 21, 2021, 10:14

added 1 commit

02a56150 - refactor: Test 코드 리펙토링

Compare with previous version

In GitLab by @gm2202985 on Jun 21, 2021, 11:20

added 2 commits

4744eb4b - fix: findByPid에서 Null 객체 반환하는 문제 수정
cf072906 - test: 크론 프로세스 서비스 통합테스트 구현

Compare with previous version

In GitLab by @gm2202985 on Jun 21, 2021, 12:05

added 1 commit

1db5dc76 - refactor: 줄 변경, CronProcessService에 private final 추가

Compare with previous version

In GitLab by @gm2202985 on Jun 21, 2021, 13:15

added 1 commit

8514f01c - refactor: 불필요한 코드 제거

Compare with previous version

In GitLab by @gm2202985 on Jun 22, 2021, 09:26

added 1 commit

2204858c - refactor: Cron process repository test에서 CronProcessRepository.save method를...

Compare with previous version

In GitLab by @gm2202985 on Jun 22, 2021, 11:45

added 1 commit

a9298776 - feat: CronLogDto 추가

Compare with previous version

In GitLab by @gm2202985 on Jun 22, 2021, 11:51

added 1 commit

9133b05d - chore: merge 충돌 해결을 위한 commit and push

Compare with previous version

In GitLab by @gm2202985 on Jun 22, 2021, 12:03

added 6 commits

9133b05d...54e2b966 - 4 commits from branch develop
0b24786d - Merge branch 'develop' of...
e332a439 - chore: Cron Server 기능 pull 후 server setIp에 대한 수정

Compare with previous version

In GitLab by @gm2202981 on Jun 22, 2021, 13:10

Commented on src/main/java/gabia/cronMonitoring/service/CronProcessService.java line 30

@AllArgsConstructor로 대체할 수 있는 부분인 것 같습니다.

In GitLab by @gm2202981 on Jun 22, 2021, 13:14

Commented on src/test/java/gabia/cronMonitoring/controller/CronProcessControllerTest.java line 165

ObjectMapper는 싱글턴으로 상속받아서 아래와 같이 수정하면 될 것 같습니다.

@Autowired
ObjectMapper mapper;

...

public void updateCronProcess() throws Exception {
    ...
    String requestJson = mapper.writeValueAsString(request);
    ...
}

In GitLab by @gm2202981 on Jun 22, 2021, 13:23

initTest 패키지 삭제 및 MySQL 테스트 리팩토링 요청드립니다.

In GitLab by @gm2202985 on Jun 22, 2021, 13:30

Commented on src/main/java/gabia/cronMonitoring/service/CronProcessService.java line 30

확인했습니다.

In GitLab by @gm2202985 on Jun 22, 2021, 14:00

Commented on src/test/java/gabia/cronMonitoring/controller/CronProcessControllerTest.java line 165

MockitoJUnitRunner로 Test를 실행하면 말씀해주신대로 Autowired 하면 의존성 주입이 진행이 되지 않아서 해당 방법으로 진행하였습니다.

In GitLab by @gm2202985 on Jun 22, 2021, 15:03

Commented on src/main/java/gabia/cronMonitoring/service/CronProcessService.java line 30

changed this line in version 10 of the diff

In GitLab by @gm2202985 on Jun 22, 2021, 15:03