Juyong / Fast_RNRR

Source code for the paper "Quasi-Newton Solver for Robust Non-Rigid Registration" (CVPR2020 Oral).

264 stars 51 forks source link

the "corres_pair_ids_" does not reflect the corresponding relationship between x and y #6

Open sun6s opened 3 years ago

sun6s commented 3 years ago

https://github.com/Juyong/Fast_RNRR/blob/b522fd00c78eaf4245c25c1ed24cc8de21735ca0/src/Registration.cpp#L129 I think the "corres_pairids" does not reflect the corresponding relationship between x and y (rig_src_v, rig_tar_v), or maybe I have a slight misunderstanding?

caijinana commented 2 years ago

Did you solve the problem?

sun6s commented 2 years ago

@caijinana In Registration::rigid_init(Mesh& src_mesh, Mesh& tar_mesh, RegParas& paras), the "corres_pairids " has been resized.

51 corres_pairids.resize(n_srcvertex);

yaoyx689 commented 2 years ago

Hi, correspondence_pairs_ reflects the corresponding pairs <source_idx, target_idx>. corres_pair_ids_ is the weight of each pair. For example, <1,2> is the first pair corresponding points by finding closest point, if it's reliable, we set corres_pair_ids_[0]=1, else set 0. There may be some ambiguity in the naming, and we will modify it or add more explanation later. Thanks for the feedback.