search

JvanKatwijk / dab-cmdline

DAB decoding library with example of its use
GNU General Public License v2.0
57 stars 29 forks source link

Reed-solomon decoder support for packet data #103

Closed SJuhl75 closed 2 months ago

SJuhl75 commented 2 months ago

Added reed-solomon decoder for packet data. Adjusted example-5 in order to receive packet data programs and output data stream via TDC port. Minor fixes (typo, readability ..)

JvanKatwijk commented 2 months ago

Thanks,

Right now my development laptop is "under repair", so I have some trouble login in into github. Since I want to understand the mod, I transferred the mods to the data processor of Qt-DAB, unfortunately that does not work properly, the RS decosing reports in 999/1000 cases that no repair is possible. Do you have by any chance a recording of a transmission that works with your mods? Would be helpful figuring out what is going on

best jan

Op vr 6 sep 2024 om 16:06 schreef Stefan Juhl @.***>:

Added reed-solomon decoder for packet data. Adjusted example-5 in order to receive packet data programs and output data stream via TDC port. Minor fixes (typo, readability ..)

You can view, comment on, or merge this pull request online at:

https://github.com/JvanKatwijk/dab-cmdline/pull/103 Commit Summary

File Changes

(9 files https://github.com/JvanKatwijk/dab-cmdline/pull/103/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQFLIN73STN4FLSNDATZVGZETAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTANJSGIZDKNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jan van Katwijk

JvanKatwijk commented 2 months ago

I suggest that you run with the address santizer enabled, it seems to give a number of overfloaws on arrays

Op za 7 sep 2024 om 19:31 schreef jan van katwijk @.***>:

Thanks,

Right now my development laptop is "under repair", so I have some trouble login in into github. Since I want to understand the mod, I transferred the mods to the data processor of Qt-DAB, unfortunately that does not work properly, the RS decosing reports in 999/1000 cases that no repair is possible. Do you have by any chance a recording of a transmission that works with your mods? Would be helpful figuring out what is going on

best jan

Op vr 6 sep 2024 om 16:06 schreef Stefan Juhl @.***>:

Added reed-solomon decoder for packet data. Adjusted example-5 in order to receive packet data programs and output data stream via TDC port. Minor fixes (typo, readability ..)

You can view, comment on, or merge this pull request online at:

https://github.com/JvanKatwijk/dab-cmdline/pull/103 Commit Summary

File Changes

(9 files https://github.com/JvanKatwijk/dab-cmdline/pull/103/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQFLIN73STN4FLSNDATZVGZETAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTANJSGIZDKNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jan van Katwijk

-- Jan van Katwijk

SJuhl75 commented 2 months ago

Hi Jan,

Thanks for your feedback; I thoroughly checked the code and created an additional function to verify the function of the Reed-Solomon Forward Error Correction. Here are the results:

I attached the updated code for reference.

Kind regards Stefan

DBG: applyFEC applyFEC::verifyRSdecoder FEC: 1598852b41ee278118c390fe8b514a9ac7e7ce4b06a00720 c25cf73c0270eb76c82b0d99da04801a5c17c4de16de33aa 185a2ffe0090d042ba052d60180fd16804fc60ac859e7ca5 940a09746923310c70c8ca8505c3924d6865914919a0ee33 c8a7fce472109fdeeeef6a408c25716122c2d614c84307b4 73819de170c43e32afa1ff62fe8f7f93fe6b239d5f24eca8 c24b00a400eb0000004600ad00eb0000004600ad00eb0000 004600ad00eb00f437c6d61f07456cf3362c6733de5aa262 6cc2caad0dad37104fa33c7b COR: 1598852b41ee278118c390fe8b514a9ac7e7ce4b06a00720 905cf73c0270eb76c82b0d99da04f21a5c17c4de16de33aa 185a2ffe0090d042ba052d60180fd16804fc60ac859e7ca5 940a09746923310c70c8ca8505b7924d68b6914919a0ee33 c8a7fce472109fdeeeef09408c25716122c2d614c84307b4 73819de170c43e32afa1ff62fe8f7f93fe6b239d5f24eca8 c24b00a400eb0000004600ad00eb00000046007f00eb0000 004600ad00eb00f437c6d61f07456cf3362c6733 REC: 1598852b41ee278118c390fe8b514a9ac7e7ce4b06a00720 c25cf73c0270eb76c82b0d99da04801a5c17c4de16de33aa 185a2ffe0090d042ba052d60180fd16804fc60ac859e7ca5 940a09746923310c70c8ca8505c3924d6865914919a0ee33 c8a7fce472109fdeeeef6a408c25716122c2d614c84307b4 73819de170c43e32afa1ff62fe8f7f93fe6b239d5f24eca8 c24b00a400eb0000004600ad00eb0000004600ad00eb0000 004600ad00eb00f437c6d61f07456cf3362c6733

Am Sa., 7. Sept. 2024 um 19:32 Uhr schrieb JvanKatwijk < @.***>:

Thanks,

Right now my development laptop is "under repair", so I have some trouble login in into github. Since I want to understand the mod, I transferred the mods to the data processor of Qt-DAB, unfortunately that does not work properly, the RS decosing reports in 999/1000 cases that no repair is possible. Do you have by any chance a recording of a transmission that works with your mods? Would be helpful figuring out what is going on

best jan

Op vr 6 sep 2024 om 16:06 schreef Stefan Juhl @.***>:

Added reed-solomon decoder for packet data. Adjusted example-5 in order to receive packet data programs and output data stream via TDC port. Minor fixes (typo, readability ..)

You can view, comment on, or merge this pull request online at:

https://github.com/JvanKatwijk/dab-cmdline/pull/103 Commit Summary

Added reed-solomon decoder for packet data. Adjusted example-5 in order to receive packet data programs and output data stream via TDC port. Minor fixes (typo, readability ..)

File Changes

(9 files https://github.com/JvanKatwijk/dab-cmdline/pull/103/files)

(1)

(5)

(3)

(99)

(4)

(29)

(491)

(2)

(2)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCPHQFLIN73STN4FLSNDATZVGZETAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTANJSGIZDKNA>

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jan van Katwijk

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103#issuecomment-2336152699, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANTWLKSASA3M5ECM375SFJDZVM2DJAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWGE2TENRZHE . You are receiving this because you authored the thread.Message ID: @.***>

SJuhl75 commented 2 months ago

Hi Jan,

to be open, I am just a hobby programmer. Anyhow I am interested in improving my code and skills. What is an address sanitizer & how to enable it?

Kind regards Stefan

Am So., 8. Sept. 2024 um 12:22 Uhr schrieb JvanKatwijk < @.***>:

I suggest that you run with the address santizer enabled, it seems to give a number of overfloaws on arrays

Op za 7 sep 2024 om 19:31 schreef jan van katwijk @.***>:

Thanks,

Right now my development laptop is "under repair", so I have some trouble login in into github. Since I want to understand the mod, I transferred the mods to the data processor of Qt-DAB, unfortunately that does not work properly, the RS decosing reports in 999/1000 cases that no repair is possible. Do you have by any chance a recording of a transmission that works with your mods? Would be helpful figuring out what is going on

best jan

Op vr 6 sep 2024 om 16:06 schreef Stefan Juhl @.***>:

Added reed-solomon decoder for packet data. Adjusted example-5 in order to receive packet data programs and output data stream via TDC port. Minor fixes (typo, readability ..)

You can view, comment on, or merge this pull request online at:

https://github.com/JvanKatwijk/dab-cmdline/pull/103 Commit Summary

Added reed-solomon decoder for packet data. Adjusted example-5 in order to receive packet data programs and output data stream via TDC port. Minor fixes (typo, readability ..)

File Changes

(9 files https://github.com/JvanKatwijk/dab-cmdline/pull/103/files)

(1)

(5)

(3)

(99)

(4)

(29)

(491)

(2)

(2)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCPHQFLIN73STN4FLSNDATZVGZETAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTANJSGIZDKNA>

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jan van Katwijk

-- Jan van Katwijk

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103#issuecomment-2336630283, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANTWLKSWRGSJ3JXCXMVEJTDZVQQPBAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWGYZTAMRYGM . You are receiving this because you authored the thread.Message ID: @.***>

JvanKatwijk commented 2 months ago

I do not doubt that the rs decoding works well, when I run with the address sanitizer library installed, there are several points where the code seems to access locations outside the allocated arrays

// Post-FEC check for efficiency of RS Decoder uint16_t lenbuf = frameBytes.size(); // fprintf (stderr,"*** DBG frameBytes [%d]\n", lenbuf);

// Loop through the frameBytes for further processing for (uint16_t j = 0; j < lenbuf / 24; j++) { // Continuity index: uint8_t cntidx = (outVector [j 24] & 0x30) >> 4; // First/Last flag: uint8_t flflg = (outVector [j 24] & 0x0c) >> 2; // Packet address uint16_t padr = (outVector [j 24] & 0x03) << 8 | outVector [j 24 + 1]; // Useful data length uint8_t udlen = outVector [j 24 + 2] & 0x7f; // Packet CRC uint16_t pcrc = (outVector [j 24 + 22]) << 8 | outVector[j * 24 + 23] (For qt-dab I changed the layout of the code somewhat)

The address sanitzer complains that when computing udlen an memory error is seen

==10551==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x51d00039ed52 at pc 0x0000005d07f7 bp 0x7f7a21dff360 sp 0x7f7a21dff358 READ of size 1 at 0x51d00039ed52 thread T37 (QThread)

0 0x5d07f6 in dataProcessor::applyFEC()

../src/backend/data/data-processor.cpp:328

1 0x5d0e3c in dataProcessor::handleRSDF(unsigned char const*)

../src/backend/data/data-processor.cpp:268

The line numbers are obviously different than in your setup

Op zo 8 sep 2024 om 15:14 schreef Stefan Juhl @.***>:

Hi Jan,

Thanks for your feedback; I thoroughly checked the code and created an additional function to verify the function of the Reed-Solomon Forward Error Correction. Here are the results:

  • The RS decoder is capable of recvoering up to six randomly corrupted bytes from a set of 188 bytes. In the output below, "FEC" is the hex dump of the FEC frame which is passed to the my_rsDecoder() as rsIn. "COR" is the hex dump of the synthically, randomly corrupted Application Data Table part of the FEC frame, which is passed as part of the FEC frame into the my_rsDecoder. "REC" ist the hex dump of the recovered rsOut array after applying my_rsDecoder. It is identical to the initial Application Data part of the FEC frame. So for my (specific) application the reed solomon forward error correction seems working very well.

I attached the updated code for reference.

Kind regards Stefan

DBG: applyFEC applyFEC::verifyRSdecoder FEC: 1598852b41ee278118c390fe8b514a9ac7e7ce4b06a00720 c25cf73c0270eb76c82b0d99da04801a5c17c4de16de33aa 185a2ffe0090d042ba052d60180fd16804fc60ac859e7ca5 940a09746923310c70c8ca8505c3924d6865914919a0ee33 c8a7fce472109fdeeeef6a408c25716122c2d614c84307b4 73819de170c43e32afa1ff62fe8f7f93fe6b239d5f24eca8 c24b00a400eb0000004600ad00eb0000004600ad00eb0000 004600ad00eb00f437c6d61f07456cf3362c6733de5aa262 6cc2caad0dad37104fa33c7b COR: 1598852b41ee278118c390fe8b514a9ac7e7ce4b06a00720 905cf73c0270eb76c82b0d99da04f21a5c17c4de16de33aa 185a2ffe0090d042ba052d60180fd16804fc60ac859e7ca5 940a09746923310c70c8ca8505b7924d68b6914919a0ee33 c8a7fce472109fdeeeef09408c25716122c2d614c84307b4 73819de170c43e32afa1ff62fe8f7f93fe6b239d5f24eca8 c24b00a400eb0000004600ad00eb00000046007f00eb0000 004600ad00eb00f437c6d61f07456cf3362c6733 REC: 1598852b41ee278118c390fe8b514a9ac7e7ce4b06a00720 c25cf73c0270eb76c82b0d99da04801a5c17c4de16de33aa 185a2ffe0090d042ba052d60180fd16804fc60ac859e7ca5 940a09746923310c70c8ca8505c3924d6865914919a0ee33 c8a7fce472109fdeeeef6a408c25716122c2d614c84307b4 73819de170c43e32afa1ff62fe8f7f93fe6b239d5f24eca8 c24b00a400eb0000004600ad00eb0000004600ad00eb0000 004600ad00eb00f437c6d61f07456cf3362c6733

Am Sa., 7. Sept. 2024 um 19:32 Uhr schrieb JvanKatwijk < @.***>:

Thanks,

Right now my development laptop is "under repair", so I have some trouble login in into github. Since I want to understand the mod, I transferred the mods to the data processor of Qt-DAB, unfortunately that does not work properly, the RS decosing reports in 999/1000 cases that no repair is possible. Do you have by any chance a recording of a transmission that works with your mods? Would be helpful figuring out what is going on

best jan

Op vr 6 sep 2024 om 16:06 schreef Stefan Juhl @.***>:

Added reed-solomon decoder for packet data. Adjusted example-5 in order to receive packet data programs and output data stream via TDC port. Minor fixes (typo, readability ..)

You can view, comment on, or merge this pull request online at:

https://github.com/JvanKatwijk/dab-cmdline/pull/103 Commit Summary

  • a201329 <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/commits/a2013294d421710f721427d6f701b67a1a5850ac>

Added reed-solomon decoder for packet data. Adjusted example-5 in order to receive packet data programs and output data stream via TDC port. Minor fixes (typo, readability ..)

File Changes

(9 files https://github.com/JvanKatwijk/dab-cmdline/pull/103/files)

  • M .gitignore <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947>

(1)

  • M devices/rtl_tcp/rtl_tcp-client.cpp <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-82271bad379ab75062cfe79b4b33a2ffab67c8d0c7852c62cce97f32b919bbd1>

(5)

  • M example-5/README <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-76b7c082ec2c78d1adffa9fccad810440fa377fcc475ac14753434241de76611>

(3)

  • M example-5/main.cpp <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-5c3adffe7b128b1c91926182116de1783aea198bc903fb2bb4b1bf9be0c3c909>

(99)

  • M example-5/server-thread/tcp-server.cpp <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-e8d231ea2749b5dbd8ecad61d9ceff833967675efb6071e03f916456189aa2e3>

(4)

  • M library/includes/backend/data/data-processor.h <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-c8fe35c280c587361d4bcb7695ad89c8b176ab9a98f93b69abd97226427202a2>

(29)

  • M library/src/backend/data/data-processor.cpp <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-744947d84cea02876aee190698820dd594d9e7b672a8e051fb4b96a65af97c2d>

(491)

  • M library/src/dab-processor.cpp <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-769325977fc79d84dc82d80f09af292a25768bc0733326cf762522e80645aaf5>

(2)

  • M library/src/ofdm/fib-processor.cpp <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-f79cdead77089af8a5d39330d924455b169f787993ad9770c33f3fbf0344efcb>

(2)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCPHQFLIN73STN4FLSNDATZVGZETAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTANJSGIZDKNA>

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jan van Katwijk

— Reply to this email directly, view it on GitHub < https://github.com/JvanKatwijk/dab-cmdline/pull/103#issuecomment-2336152699>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/ANTWLKSASA3M5ECM375SFJDZVM2DJAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWGE2TENRZHE>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103#issuecomment-2336682382, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQG73NUEZWS4LBMKCSDZVRESPAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWGY4DEMZYGI . You are receiving this because you commented.Message ID: @.***>

-- Jan van Katwijk

JvanKatwijk commented 2 months ago

First of all, your code is really appreciated, not problem there, second if you discard optimizations and add -g -fsanitize=address

to the compiler and loader flags the sanitizer library is attached that controls accesses to allocated data

Op zo 8 sep 2024 om 15:16 schreef Stefan Juhl @.***>:

Hi Jan,

to be open, I am just a hobby programmer. Anyhow I am interested in improving my code and skills. What is an address sanitizer & how to enable it?

Kind regards Stefan

Am So., 8. Sept. 2024 um 12:22 Uhr schrieb JvanKatwijk < @.***>:

I suggest that you run with the address santizer enabled, it seems to give a number of overfloaws on arrays

Op za 7 sep 2024 om 19:31 schreef jan van katwijk @.***>:

Thanks,

Right now my development laptop is "under repair", so I have some trouble login in into github. Since I want to understand the mod, I transferred the mods to the data processor of Qt-DAB, unfortunately that does not work properly, the RS decosing reports in 999/1000 cases that no repair is possible. Do you have by any chance a recording of a transmission that works with your mods? Would be helpful figuring out what is going on

best jan

Op vr 6 sep 2024 om 16:06 schreef Stefan Juhl @.***>:

Added reed-solomon decoder for packet data. Adjusted example-5 in order to receive packet data programs and output data stream via TDC port. Minor fixes (typo, readability ..)

You can view, comment on, or merge this pull request online at:

https://github.com/JvanKatwijk/dab-cmdline/pull/103 Commit Summary

  • a201329 <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/commits/a2013294d421710f721427d6f701b67a1a5850ac>

Added reed-solomon decoder for packet data. Adjusted example-5 in order to receive packet data programs and output data stream via TDC port. Minor fixes (typo, readability ..)

File Changes

(9 files https://github.com/JvanKatwijk/dab-cmdline/pull/103/files)

  • M .gitignore <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947>

(1)

  • M devices/rtl_tcp/rtl_tcp-client.cpp <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-82271bad379ab75062cfe79b4b33a2ffab67c8d0c7852c62cce97f32b919bbd1>

(5)

  • M example-5/README <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-76b7c082ec2c78d1adffa9fccad810440fa377fcc475ac14753434241de76611>

(3)

  • M example-5/main.cpp <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-5c3adffe7b128b1c91926182116de1783aea198bc903fb2bb4b1bf9be0c3c909>

(99)

  • M example-5/server-thread/tcp-server.cpp <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-e8d231ea2749b5dbd8ecad61d9ceff833967675efb6071e03f916456189aa2e3>

(4)

  • M library/includes/backend/data/data-processor.h <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-c8fe35c280c587361d4bcb7695ad89c8b176ab9a98f93b69abd97226427202a2>

(29)

  • M library/src/backend/data/data-processor.cpp <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-744947d84cea02876aee190698820dd594d9e7b672a8e051fb4b96a65af97c2d>

(491)

  • M library/src/dab-processor.cpp <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-769325977fc79d84dc82d80f09af292a25768bc0733326cf762522e80645aaf5>

(2)

  • M library/src/ofdm/fib-processor.cpp <

https://github.com/JvanKatwijk/dab-cmdline/pull/103/files#diff-f79cdead77089af8a5d39330d924455b169f787993ad9770c33f3fbf0344efcb>

(2)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ACCPHQFLIN73STN4FLSNDATZVGZETAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTANJSGIZDKNA>

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Jan van Katwijk

-- Jan van Katwijk

— Reply to this email directly, view it on GitHub < https://github.com/JvanKatwijk/dab-cmdline/pull/103#issuecomment-2336630283>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/ANTWLKSWRGSJ3JXCXMVEJTDZVQQPBAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWGYZTAMRYGM>

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103#issuecomment-2336683033, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQGSP5T63KILJA73V7TZVREZ7AVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZWGY4DGMBTGM . You are receiving this because you commented.Message ID: @.***>

-- Jan van Katwijk

SJuhl75 commented 2 months ago

Dear Jan, in the latest commit I made adjustments to the code, so that it runs flawless with TPEG and PPP-RTK-AdV program in southern germany. TPEG has a packelength of 48 bytes; the RS Data field packet of 24 bytes are provided consecutively by the datastream. It was also necessary to adjust the tdc-datahandler.cpp, in terms of datagroup / TPEG dataframe CRC calculation, as the PPP-RTK-AdV does not supply a syncword 0xff0f like TPEG does. Kind regards Stefan

andimik commented 2 months ago

@JvanKatwijk

He has published his commit at https://github.com/SJuhl75/dab-cmdline/commit/806f450e2a7a32214ae4b80065490ffcd6c8bbf3

JvanKatwijk commented 2 months ago

Just a question In example 2 an interface is specified to a tpeghandler, are the changes you want to make compatible with this interface?

Op ma 23 sep 2024 om 08:24 schreef andimik @.***>:

@JvanKatwijk https://github.com/JvanKatwijk

He has published his commit at @.*** https://github.com/SJuhl75/dab-cmdline/commit/806f450e2a7a32214ae4b80065490ffcd6c8bbf3

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103#issuecomment-2367321071, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQAENVOFT5GSEV6D4WDZX6XYLAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXGMZDCMBXGE . You are receiving this because you were mentioned.Message ID: @.***>

-- Jan van Katwijk

SJuhl75 commented 2 months ago

Hi Jan, I did not check this recently / I was not aware of example 2. I will check it and come back to you. Kind regards Stefan

Am Mo., 23. Sept. 2024 um 13:00 Uhr schrieb JvanKatwijk < @.***>:

Just a question In example 2 an interface is specified to a tpeghandler, are the changes you want to make compatible with this interface?

Op ma 23 sep 2024 om 08:24 schreef andimik @.***>:

@JvanKatwijk https://github.com/JvanKatwijk

He has published his commit at @.*** < https://github.com/SJuhl75/dab-cmdline/commit/806f450e2a7a32214ae4b80065490ffcd6c8bbf3>

— Reply to this email directly, view it on GitHub < https://github.com/JvanKatwijk/dab-cmdline/pull/103#issuecomment-2367321071>,

or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACCPHQAENVOFT5GSEV6D4WDZX6XYLAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXGMZDCMBXGE>

. You are receiving this because you were mentioned.Message ID: @.***>

-- Jan van Katwijk

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103#issuecomment-2367882972, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANTWLKVUZG4RWGT3XV2SIJTZX7YGFAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRXHA4DEOJXGI . You are receiving this because you authored the thread.Message ID: @.***>

SJuhl75 commented 2 months ago

Hi Jan, yes, it seems to be compatible. I did not change the basic handling concept of TPEG frames in the code provided. So, if the receiver application is tuned to a TPEG packetdata program, the TPEG frames will be recognized based on the syncword and processed on the frametype of the TPEG frame. Otherwise, if the syncword 0xff0f is not found (e.g. when using the PPP-RTK-AdV program), the MSC datagroup will be put out. Kind regards Stefan ------- GitHub Codespace Terminal Output below --------- @SJuhl75 ➜ /workspaces/…/dab-cmdline/example-2/build (packetDataRS) $ cmake .. -DRTL_TCP=1
CMake Warning (dev) in CMakeLists.txt: No project() command is present. The top-level CMakeLists.txt file must contain a literal, direct call to the project() command. Add a line of code such as

project(ProjectName)

near the top of the file, but after cmake_minimum_required().

CMake is pretending there is a "project(Project)" command on the first line. This warning is for project developers. Use -Wno-dev to suppress it.

-- The C compiler identification is GNU 10.2.1 -- The CXX compiler identification is GNU 10.2.1 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Build type not specified: defaulting to release. -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2") CMake Warning (dev) at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:273 (message): The package name passed to find_package_handle_standard_args (PkgConfig) does not match the name of the calling package (FFTW3f). This can lead to problems in calling code that expects find_package result variables (e.g., _FOUND) to follow a certain pattern. Call Stack (most recent call first): /usr/share/cmake-3.18/Modules/FindPkgConfig.cmake:59 (find_package_handle_standard_args) cmake/Modules/FindFFTW3f.cmake:6 (INCLUDE) CMakeLists.txt:163 (find_package) This warning is for project developers. Use -Wno-dev to suppress it.

-- Checking for module 'fftw3f >= 3.0' -- Found fftw3f , version 3.3.8 -- Found FFTW3f: /usr/lib/x86_64-linux-gnu/libfftw3f.so
-- Found LibSampleRate: CMake Warning (dev) at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:273 (message): The package name passed to find_package_handle_standard_args (PkgConfig) does not match the name of the calling package (Portaudio). This can lead to problems in calling code that expects find_package result variables (e.g., _FOUND) to follow a certain pattern. Call Stack (most recent call first): /usr/share/cmake-3.18/Modules/FindPkgConfig.cmake:59 (find_package_handle_standard_args) cmake/Modules/FindPortaudio.cmake:8 (include) CMakeLists.txt:180 (find_package) This warning is for project developers. Use -Wno-dev to suppress it.

-- Checking for module 'portaudio-2.0' -- Found portaudio-2.0, version 19 -- Performing Test PORTAUDIO2_FOUND -- Performing Test PORTAUDIO2_FOUND - Success CMake Warning (dev) at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:273 (message): The package name passed to find_package_handle_standard_args (PORTAUDIO) does not match the name of the calling package (Portaudio). This can lead to problems in calling code that expects find_package result variables (e.g., _FOUND) to follow a certain pattern. Call Stack (most recent call first): cmake/Modules/FindPortaudio.cmake:46 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:180 (find_package) This warning is for project developers. Use -Wno-dev to suppress it.

-- Found PORTAUDIO: /usr/include
-- Found LibSndFile: /usr/lib/x86_64-linux-gnu/libsndfile.so -- Found zlib: -- Configuring done -- Generating done -- Build files have been written to: /workspaces/codespaces-openvpn/dab-cmdline/example-2/build @SJuhl75 ➜ /workspaces/…/dab-cmdline/example-2/build (packetDataRS) $ make Scanning dependencies of target dab-rtl_tcp-2 [ 2%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/devices/rtl_tcp/rtl_tcp-client.cpp.o [ 4%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/main.cpp.o [ 6%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/audio-sink/audio-base.cpp.o [ 8%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/audio-sink/audiosink.cpp.o [ 10%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/audio-sink/filesink.cpp.o [ 12%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/audio-sink/newconverter.cpp.o [ 14%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/server-thread/tcp-server.cpp.o [ 17%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/devices/device-handler.cpp.o [ 19%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/dab-api.cpp.o [ 21%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/dab-processor.cpp.o [ 23%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/ofdm-decoder.cpp.o [ 25%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/phasereference.cpp.o [ 27%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/phasetable.cpp.o [ 29%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/freq-interleaver.cpp.o [ 31%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/timesyncer.cpp.o [ 34%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/sample-reader.cpp.o [ 36%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/fib-processor.cpp.o [ 38%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/fic-handler.cpp.o [ 40%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/tii-detector.cpp.o [ 42%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/firecode-checker.cpp.o [ 44%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/backend-base.cpp.o [ 46%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/charsets.cpp.o [ 48%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/galois.cpp.o [ 51%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/reed-solomon.cpp.o [ 53%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/msc-handler.cpp.o [ 55%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/virtual-backend.cpp.o [ 57%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/audio-backend.cpp.o [ 59%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data-backend.cpp.o [ 61%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/audio/mp4processor.cpp.o [ 63%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/audio/mp2processor.cpp.o [ 65%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/virtual-datahandler.cpp.o [ 68%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/tdc-datahandler.cpp.o /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/tdc-datahandler.cpp: In member function ‘virtual void tdc_dataHandler::add_mscDatagroup(std::vector)’: /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/tdc-datahandler.cpp:108:13: warning: unused variable ‘rfa’ [-Wunused-variable] 108 | uint8_t rfa = (segfld==1)?getBits (data, 24+extfld16, 3):0; // Reserved for future use | ^~~ /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/tdc-datahandler.cpp:109:13: warning: unused variable ‘tidflg’ [-Wunused-variable] 109 | uint8_t tidflg = (segfld==1)?getBits (data, 27+extfld16, 1):0; // Transport Identifier flag | ^~ /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/tdc-datahandler.cpp:111:13: warning: unused variable ‘tid’ [-Wunused-variable] 111 | uint16_t tid = (segfld==1)?getBits (data, 32+extfld16, 16):0; // Transport Identifier | ^~~ [ 70%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/pad-handler.cpp.o [ 72%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/mot/mot-handler.cpp.o [ 74%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/mot/mot-dir.cpp.o [ 76%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/mot/mot-object.cpp.o [ 78%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/data-processor.cpp.o /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/data-processor.cpp: In member function ‘void dataProcessor::handlePackets(uint8_t, int16_t)’: /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/data-processor.cpp:329:14: warning: variable ‘ccrc’ set but not used [-Wunused-but-set-variable] 329 | uint16_t ccrc; // = calc_crc_bits(data, (packetLength - 2) * 8); | ^~~~ /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/data-processor.cpp: In member function ‘void dataProcessor::processPacketStream()’: /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/data-processor.cpp:739:13: warning: ‘dfoff’ may be used uninitialized in this function [-Wmaybe-uninitialized] 739 | uint8_t dfoff; // Data field offset | ^~~~~ [ 80%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/band-handler.cpp.o [ 82%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/protTables.cpp.o [ 85%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/protection.cpp.o [ 87%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/eep-protection.cpp.o [ 89%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/uep-protection.cpp.o [ 91%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/fft-handler.cpp.o [ 93%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/dab-params.cpp.o [ 95%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/viterbi-spiral/viterbi-spiral.cpp.o [ 97%] Building C object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/viterbi-spiral/spiral-no-sse.c.o [100%] Linking CXX executable dab-rtl_tcp-2 [100%] Built target dab-rtl_tcp-2 @SJuhl75 ➜ /workspaces/…/dab-cmdline/example-2/build (packetDataRS) $ ./dab-rtl_tcp-2 -H 192.168.178.61 -O /dev/null -C 5C -G 20
dab_cmdline example II, Copyright 2017 J van Katwijk, Lazy Chair Computing options are T:D:d:M:B:P:O:A:C:G:Qp:H:I trying to open /dev/null Opened /dev/null server address = 192.168.178.61, port 1234 setting the rate to 2048000 setting the frequency to 178352000 setting the gain to 20 there might be a DAB signal here program EPG Deutschland (data) is part of the ensemble program TPEG_MM (data) is part of the ensemble program radio horeb is part of the ensemble program KLASSIK RADIO is part of the ensemble program SUNSHINE LIVE is part of the ensemble program DRadio DokDeb is part of the ensemble program SCHLAGERPARADIES is part of the ensemble program Absolut relax is part of the ensemble program RADIO BOB! is part of the ensemble program Schwarzwaldradio is part of the ensemble program ENERGY is part of the ensemble program PPP-RTK-AdV (data) is part of the ensemble program Dlf Kultur is part of the ensemble program DRadio Daten (data) is part of the ensemble mainId 11, subId 2 ensemble DR Deutschland is (10BC) recognized program Dlf Nova is part of the ensemble program ERF Plus is part of the ensemble program TPEG (data) is part of the ensemble program Dlf is part of the ensemble mainId 11, subId 2

mainId 11, subId 2 mainId 11, subId 2 mainId 11, subId 2 mainId 11, subId 2 mainId 11, subId 2 we try to start program Sky Radio sorry we cannot handle service Sky Radio mainId 11, subId 2 dab processor will stop

JvanKatwijk commented 2 months ago

The only code I see sofar in the oull request is the code from a couple of weeks back

Op ma 23 sep 2024 om 22:45 schreef Stefan Juhl @.***>:

Hi Jan, yes, it seems to be compatible. I did not change the basic handling concept of TPEG frames in the code provided. So, if the receiver application is tuned to a TPEG packetdata program, the TPEG frames will be recognized based on the syncword and processed on the frametype of the TPEG frame. Otherwise, if the syncword 0xff0f is not found (e.g. when using the PPP-RTK-AdV program), the MSC datagroup will be put out. Kind regards Stefan ------- GitHub Codespace Terminal Output below --------- @SJuhl75 https://github.com/SJuhl75 ➜ /workspaces/…/dab-cmdline/example-2/build (packetDataRS) $ cmake .. -DRTL_TCP=1 CMake Warning (dev) in CMakeLists.txt: No project() command is present. The top-level CMakeLists.txt file must contain a literal, direct call to the project() command. Add a line of code such as

project(ProjectName)

near the top of the file, but after cmake_minimum_required().

CMake is pretending there is a "project(Project)" command on the first line. This warning is for project developers. Use -Wno-dev to suppress it.

-- The C compiler identification is GNU 10.2.1 -- The CXX compiler identification is GNU 10.2.1 -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working C compiler: /usr/bin/cc - skipped -- Detecting C compile features -- Detecting C compile features - done -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Build type not specified: defaulting to release. -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2") CMake Warning (dev) at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:273 (message): The package name passed to find_package_handle_standard_args (PkgConfig) does not match the name of the calling package (FFTW3f). This can lead to problems in calling code that expects find_package result variables (e.g., _FOUND) to follow a certain pattern. Call Stack (most recent call first): /usr/share/cmake-3.18/Modules/FindPkgConfig.cmake:59 (find_package_handle_standard_args) cmake/Modules/FindFFTW3f.cmake:6 (INCLUDE) CMakeLists.txt:163 (find_package) This warning is for project developers. Use -Wno-dev to suppress it.

-- Checking for module 'fftw3f >= 3.0' -- Found fftw3f , version 3.3.8 -- Found FFTW3f: /usr/lib/x86_64-linux-gnu/libfftw3f.so -- Found LibSampleRate: CMake Warning (dev) at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:273 (message): The package name passed to find_package_handle_standard_args (PkgConfig) does not match the name of the calling package (Portaudio). This can lead to problems in calling code that expects find_package result variables (e.g., _FOUND) to follow a certain pattern. Call Stack (most recent call first): /usr/share/cmake-3.18/Modules/FindPkgConfig.cmake:59 (find_package_handle_standard_args) cmake/Modules/FindPortaudio.cmake:8 (include) CMakeLists.txt:180 (find_package) This warning is for project developers. Use -Wno-dev to suppress it.

-- Checking for module 'portaudio-2.0' -- Found portaudio-2.0, version 19 -- Performing Test PORTAUDIO2_FOUND -- Performing Test PORTAUDIO2_FOUND - Success CMake Warning (dev) at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:273 (message): The package name passed to find_package_handle_standard_args (PORTAUDIO) does not match the name of the calling package (Portaudio). This can lead to problems in calling code that expects find_package result variables (e.g., _FOUND) to follow a certain pattern. Call Stack (most recent call first): cmake/Modules/FindPortaudio.cmake:46 (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:180 (find_package) This warning is for project developers. Use -Wno-dev to suppress it.

-- Found PORTAUDIO: /usr/include -- Found LibSndFile: /usr/lib/x86_64-linux-gnu/libsndfile.so -- Found zlib: -- Configuring done -- Generating done -- Build files have been written to: /workspaces/codespaces-openvpn/dab-cmdline/example-2/build @SJuhl75 https://github.com/SJuhl75 ➜ /workspaces/…/dab-cmdline/example-2/build (packetDataRS) $ make Scanning dependencies of target dab-rtl_tcp-2 [ 2%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/devices/rtl_tcp/rtl_tcp-client.cpp.o [ 4%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/main.cpp.o [ 6%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/audio-sink/audio-base.cpp.o [ 8%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/audio-sink/audiosink.cpp.o [ 10%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/audio-sink/filesink.cpp.o [ 12%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/audio-sink/newconverter.cpp.o [ 14%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/server-thread/tcp-server.cpp.o [ 17%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/devices/device-handler.cpp.o [ 19%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/dab-api.cpp.o [ 21%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/dab-processor.cpp.o [ 23%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/ofdm-decoder.cpp.o [ 25%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/phasereference.cpp.o [ 27%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/phasetable.cpp.o [ 29%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/freq-interleaver.cpp.o [ 31%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/timesyncer.cpp.o [ 34%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/sample-reader.cpp.o [ 36%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/fib-processor.cpp.o [ 38%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/fic-handler.cpp.o [ 40%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/ofdm/tii-detector.cpp.o [ 42%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/firecode-checker.cpp.o [ 44%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/backend-base.cpp.o [ 46%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/charsets.cpp.o [ 48%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/galois.cpp.o [ 51%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/reed-solomon.cpp.o [ 53%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/msc-handler.cpp.o [ 55%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/virtual-backend.cpp.o [ 57%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/audio-backend.cpp.o [ 59%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data-backend.cpp.o [ 61%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/audio/mp4processor.cpp.o [ 63%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/audio/mp2processor.cpp.o [ 65%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/virtual-datahandler.cpp.o [ 68%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/tdc-datahandler.cpp.o /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/tdc-datahandler.cpp: In member function ‘virtual void tdc_dataHandler::add_mscDatagroup(std::vector)’: /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/tdc-datahandler.cpp:108:13: warning: unused variable ‘rfa’ [-Wunused-variable] 108 | uint8_t rfa = (segfld==1)?getBits (data, 24+extfld

16, 3):0; // Reserved for future use | ^~~ /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/tdc-datahandler.cpp:109:13: warning: unused variable ‘tidflg’ [-Wunused-variable] 109 | uint8_t tidflg = (segfld==1)?getBits (data, 27+extfld16, 1):0; // Transport Identifier flag | ^~ /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/tdc-datahandler.cpp:111:13: warning: unused variable ‘tid’ [-Wunused-variable] 111 | uint16_t tid = (segfld==1)?getBits (data, 32+extfld

16, 16):0; // Transport Identifier | ^~~ [ 70%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/pad-handler.cpp.o [ 72%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/mot/mot-handler.cpp.o [ 74%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/mot/mot-dir.cpp.o [ 76%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/mot/mot-object.cpp.o [ 78%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/data-processor.cpp.o /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/data-processor.cpp: In member function ‘void dataProcessor::handlePackets(uint8_t, int16_t)’: /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/data-processor.cpp:329:14: warning: variable ‘ccrc’ set but not used [-Wunused-but-set-variable] 329 | uint16_t ccrc; // = calc_crc_bits(data, (packetLength - 2) * 8); | ^~~~ /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/data-processor.cpp: In member function ‘void dataProcessor::processPacketStream()’: /workspaces/codespaces-openvpn/dab-cmdline/library/src/backend/data/data-processor.cpp:739:13: warning: ‘dfoff’ may be used uninitialized in this function [-Wmaybe-uninitialized] 739 | uint8_t dfoff; // Data field offset | ^~~~~ [ 80%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/band-handler.cpp.o [ 82%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/protTables.cpp.o [ 85%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/protection.cpp.o [ 87%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/eep-protection.cpp.o [ 89%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/uep-protection.cpp.o [ 91%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/fft-handler.cpp.o [ 93%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/dab-params.cpp.o [ 95%] Building CXX object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/viterbi-spiral/viterbi-spiral.cpp.o [ 97%] Building C object CMakeFiles/dab-rtl_tcp-2.dir/workspaces/codespaces-openvpn/dab-cmdline/library/src/support/viterbi-spiral/spiral-no-sse.c.o [100%] Linking CXX executable dab-rtl_tcp-2 [100%] Built target dab-rtl_tcp-2 @SJuhl75 https://github.com/SJuhl75 ➜ /workspaces/…/dab-cmdline/example-2/build (packetDataRS) $ ./dab-rtl_tcp-2 -H 192.168.178.61 -O /dev/null -C 5C -G 20 dab_cmdline example II, Copyright 2017 J van Katwijk, Lazy Chair Computing options are T:D:d:M:B:P:O:A:C:G:Qp:H:I trying to open /dev/null Opened /dev/null server address = 192.168.178.61, port 1234 setting the rate to 2048000 setting the frequency to 178352000 setting the gain to 20 there might be a DAB signal here program EPG Deutschland (data) is part of the ensemble program TPEG_MM (data) is part of the ensemble program radio horeb is part of the ensemble program KLASSIK RADIO is part of the ensemble program SUNSHINE LIVE is part of the ensemble program DRadio DokDeb is part of the ensemble program SCHLAGERPARADIES is part of the ensemble program Absolut relax is part of the ensemble program RADIO BOB! is part of the ensemble program Schwarzwaldradio is part of the ensemble program ENERGY is part of the ensemble program PPP-RTK-AdV (data) is part of the ensemble program Dlf Kultur is part of the ensemble program DRadio Daten (data) is part of the ensemble mainId 11, subId 2 ensemble DR Deutschland is (10BC) recognized program Dlf Nova is part of the ensemble program ERF Plus is part of the ensemble program TPEG (data) is part of the ensemble program Dlf is part of the ensemble mainId 11, subId 2

mainId 11, subId 2 mainId 11, subId 2 mainId 11, subId 2 mainId 11, subId 2 mainId 11, subId 2 we try to start program Sky Radio sorry we cannot handle service Sky Radio mainId 11, subId 2 dab processor will stop

— Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/103#issuecomment-2369347492, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQDD3WZ436A5O7GB3JTZYB4WPAVCNFSM6AAAAABNYVDC6GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRZGM2DONBZGI . You are receiving this because you were mentioned.Message ID: @.***>

-- Jan van Katwijk

SJuhl75 commented 2 months ago

See commit https://github.com/JvanKatwijk/dab-cmdline/commit/806f450e2a7a32214ae4b80065490ffcd6c8bbf3 from two days ago?