search

JvanKatwijk / dab-cmdline

DAB decoding library with example of its use
GNU General Public License v2.0
57 stars 29 forks source link

ofdm: use zero Khz correction #31

Closed athoik closed 6 years ago

athoik commented 6 years ago

just like welle.io does https://github.com/AlbrechtL/welle.io/blob/master/src/ofdm/ofdm-processor.cpp#L401-L405

There are reports from several people, mentioning that after applying that patch, sync seems much faster.

JvanKatwijk commented 6 years ago

Are you sure it is better? It looks like Welle.io still uses my original code. I changed that since I felt that convergence was much slower when resetting to zero. But I do not have any objection changing that

2018-01-10 21:31 GMT+01:00 Athanasios Oikonomou notifications@github.com:

just like welle.io does https://github.com/AlbrechtL/ welle.io/blob/master/src/ofdm/ofdm-processor.cpp#L401-L405

There are reports from several people, mentioning that after applying that patch, sync seems much faster.

You can view, comment on, or merge this pull request online at:

https://github.com/JvanKatwijk/dab-cmdline/pull/31 Commit Summary

  • ofdm: use zero Khz correction

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/31, or mute the thread https://github.com/notifications/unsubscribe-auth/AITzwNgI1cF-cv8pT78zFU5URQ20n6T7ks5tJR4tgaJpZM4RZ5yo .

-- Jan van Katwijk

+31 (0)15 3698980 +31 (0) 628260355

athoik commented 6 years ago

Yes this is the feedback I got from several people:

https://forums.openpli.org/topic/56134-dab-radio-reception/page-12#entry826910 https://forums.openpli.org/topic/56134-dab-radio-reception/page-12#entry827060 https://www.satdreamgr.com/forum/showthread.php?14653-RTL-SDR-with-Enigma2-%28SDG-Radio%29&p=109025&viewfull=1#post109025

I don't have any profession way to test it, but that's the feeling most user have, now that we reset back to 0 instead towards to outer frequency limits.

JvanKatwijk commented 6 years ago

done

athoik commented 6 years ago

Thank you!