search

JvanKatwijk / dab-cmdline

DAB decoding library with example of its use
GNU General Public License v2.0
57 stars 29 forks source link

mot-object: does not save object to filesystem #66

Closed athoik closed 4 years ago

athoik commented 4 years ago

Hi,

It seems that mot-object doesn't save images to filesystem any more.

https://github.com/JvanKatwijk/dab-cmdline/blob/252ab7fd2665e1ebd55fa7e887d20df4c1e1b2fa/library/src/backend/data/mot/mot-object.cpp#L163-L173

It was disabled on: https://github.com/JvanKatwijk/dab-cmdline/commit/d858f4f49cb5f04a2dd959959b27cb68f3f4a33c

(but before disable, it was written on working directory, instead of /tmp)

I restore it like this:

https://github.com/satdreamgr/dab-cmdline/blob/dev/library/src/backend/data/mot/mot-object.cpp#L164-L176

Obviously if there is no motdataHandler we can simply return immediately from handleComplete.

Restore this functionality?

JvanKatwijk commented 4 years ago

I do not have a problem with that, the reason the objects were not saved was a user request to stop automatic saving. Actually I think it should be done in the user handler, rather than from deep inside the code I'll have a good look

Op di 14 apr. 2020 om 23:13 schreef Athanasios Oikonomou < notifications@github.com>:

Hi,

It seems that mot-object doesn't save images to filesystem any more.

https://github.com/JvanKatwijk/dab-cmdline/blob/252ab7fd2665e1ebd55fa7e887d20df4c1e1b2fa/library/src/backend/data/mot/mot-object.cpp#L163-L173

It was disabled on: d858f4f https://github.com/JvanKatwijk/dab-cmdline/commit/d858f4f49cb5f04a2dd959959b27cb68f3f4a33c

(but before disable, it was written on working directory, instead of /tmp)

I restore it like this:

https://github.com/satdreamgr/dab-cmdline/blob/dev/library/src/backend/data/mot/mot-object.cpp#L164-L176

Obviously if there is no motdataHandler we can simply return immediately from handleComplete.

Restore this functionality?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/issues/66, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQEABKS27VD7NLJYWZLRMTGYHANCNFSM4MIB4J3Q .

-- Jan van Katwijk

JvanKatwijk commented 4 years ago

I changed the code: if a handler is present then the object is written as a file in /tmp if no handler is preset, object is ignored

athoik commented 4 years ago

And that perfectly makes sense! Thank you!