search

JvanKatwijk / dab-cmdline

DAB decoding library with example of its use
GNU General Public License v2.0
57 stars 29 forks source link

dab-library CMakeLists.txt doesn't force C++ 11 support #7

Closed rickwookie closed 7 years ago

rickwookie commented 7 years ago

To compile dab-library, the README file states: "IMPORTANT: YOU NEED C++11 SUPPORT FOR THIS", which I found to be the case (it wouldn't compile without!), so could the CMakeLists.txt not include 'add_compile_options(-std=c++11)' to facilitate this, or does this compile option break with newer versions of cmake (that perhaps already use C++ 11 by default)?

JvanKatwijk commented 7 years ago

Good point, I'll see to it. Jan

2017-03-17 12:48 GMT+01:00 rickwookie notifications@github.com:

To compile dab-library, the README file states: "IMPORTANT: YOU NEED C++11 SUPPORT FOR THIS", which I found to be the case (it wouldn't compile without!), so could the CMakeLists.txt not include 'add_compile_options(-std=c++11)' to facilitate this, or does this compile option break with newer versions of cmake (that perhaps already use C++ 11 by default)?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/issues/7, or mute the thread https://github.com/notifications/unsubscribe-auth/AITzwPjsfCtUj_XevQ2fPSRnz1n28D7Iks5rmnMJgaJpZM4Mgffj .

-- Jan van Katwijk

+31 (0)15 3698980 +31 (0) 628260355

rickwookie commented 7 years ago

Nice one, that now compiles as-is (with of course the un-commenting of the correct hardware type in the READ THIS section, as expected). Hopefully that hasn't broken it for anyone else with other versions of cmake. ;-)