Closed srcejon closed 3 years ago
OK, Sounds interesting (for a non-windows user at least)
Op za 17 apr. 2021 om 00:09 schreef srcejon @.***>:
Hi,
I've integrated your DAB library in to SDRangel. In order for it to be able to be compiled as a DLL for Windows using MSVC, the following changes were needed.
A note for anyone who uses it: because std::string is used in the API, the DLL and application that uses it needs to be compiled with the same version of MSVC with same release/debug compilation settings.
You can view, comment on, or merge this pull request online at:
https://github.com/JvanKatwijk/dab-cmdline/pull/71 Commit Summary
- Export DAB API functions from DLL
- Add MSVC support to CMakeFiles and fix paths to fftw3
- Allow code to be compiled with MSVC
- Remove submodule
File Changes
- M dab-api.h https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-4e2cb00387a059a4807c4bb6c10f5a99bcfec12322e5a4c612f4b8c6dd2a6c1a (42)
- M library/CMakeLists.txt https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-9504fe9e5bb5a14156c9bda58abf4040e06b2a1a9debcea7d87b4bb45dfe8772 (10)
- M library/cmake/Modules/FindFFTW3f.cmake https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-dda8ff4fc0ec15000a86b25359336b63f3fc0368530b034accb8c3bf72a42422 (2)
- M library/dab-api.cpp https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-9ae61da84c7668996811aaf9d51a3cb40309ab3663949ac33d9392cab63a128f (24)
- M library/includes/dab-constants.h https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-5f2a096e313694b96e0ab6fd01d43a5c0a596892b6c5b14be5372246bc203653 (14)
- M library/includes/support/viterbi-spiral/viterbi-spiral.h https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-25d3e546d716490a08059d86b418d0d43907abf5fa26a067de57a8af8dd11b23 (16)
- M library/src/backend/audio/mp2processor.cpp https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-ea2e9ed4bb8b7be9faeb965a8e370942e61c835834c22c3c5e71b6284fdb1a85 (4)
- M library/src/backend/audio/mp4processor.cpp https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-10e909c79557b3491745f0d999aa74506955bbd9f47041413d298aa53f734182 (4)
- M library/src/backend/data/tdc-datahandler.cpp https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-40203188088c5b8faa4095b96440979ebd598b1e9e1b5189e4aa936dbac2b87b (8)
- M library/src/backend/msc-handler.cpp https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-d8371756a5798a18956de756a23b02743e3813ed37b18a9977ab630f6925c01d (4)
- M library/src/backend/reed-solomon.cpp https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-bd782b14ebf8407f9c0e7770c160fddfd35205474a1b2f33eeab5f3c5c59784c (34)
- M library/src/ofdm/ofdm-decoder.cpp https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-de2a1c15e88e4861dca911a321e188a1f0f967edd510d9763ccd129c9ce37ea0 (4)
- M library/src/ofdm/phasereference.cpp https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-f6bac3901185c37e61b0362403f8ec4f9849b66f96506b61792bc3d24711bd4f (4)
- M library/src/ofdm/timesyncer.cpp https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-f2a04a5d8645cbe6b59a466fca9746201da9978cbf64e22dc95f767699ebe3a3 (4)
- D library/src/support/viterbi-spiral/sse2neon https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-b121dfe276f7796b3fe732e0746ec61f55ab0f0f578d59afe0ebd1599d535eeb (1)
- M library/src/support/viterbi-spiral/viterbi-spiral.cpp https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-e069e606ddcfcc2935c3b18f9f29039c33ed2c5bcbbe8044d435f3226a9724b1 (6)
- M ringbuffer.h https://github.com/JvanKatwijk/dab-cmdline/pull/71/files#diff-c99a51ece3dda7c11ba387037be8fe847c22a6848a0f6ff21db9cabe7d1a6493 (5)
Patch Links:
- https://github.com/JvanKatwijk/dab-cmdline/pull/71.patch
- https://github.com/JvanKatwijk/dab-cmdline/pull/71.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JvanKatwijk/dab-cmdline/pull/71, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCPHQFLWAJ7VFZBBXBZYITTJCYQRANCNFSM43CJ7OVQ .
-- Jan van Katwijk
Thanks for the merge. It runs on Linux (and Mac) as well: https://github.com/f4exb/sdrangel
Hi,
I've integrated your DAB library in to SDRangel. In order for it to be able to be compiled as a DLL for Windows using MSVC, the following changes were needed.
A note for anyone who uses it: because std::string is used in the API, the DLL and application that uses it needs to be compiled with the same version of MSVC with same release/debug compilation settings.